stop replReducer setting isRunning to true when using conductor, as it should be a no-op

also change featureSelector to take a flag instead of just its name

Author: tsammeow

src/commons/featureFlags/featureSelector.ts

@@ -1,4 +1,5 @@
 import { OverallState } from '../application/ApplicationTypes';
+import { FeatureFlag } from './FeatureFlag';
 
-export const featureSelector = (flagName: string) => (state: OverallState) =>
-  state.featureFlags.modifiedFlags[flagName];
+export const featureSelector = (featureFlag: FeatureFlag<any>) => (state: OverallState) =>
+  state.featureFlags.modifiedFlags[featureFlag.flagName];

src/commons/featureFlags/selectFeatureSaga.ts

@@ -5,7 +5,7 @@ import { FeatureFlag } from './FeatureFlag';
 import { featureSelector } from './featureSelector';
 
 export function* selectFeatureSaga<T>(featureFlag: FeatureFlag<T>): SagaIterator<T> {
-  const { flagName, defaultValue } = featureFlag;
-  const flagValue = yield select(featureSelector(flagName));
+  const { defaultValue } = featureFlag;
+  const flagValue = yield select(featureSelector(featureFlag));
   return flagValue ?? defaultValue;
 }

src/commons/workspace/reducers/replReducer.ts

@@ -1,4 +1,6 @@
 import { ActionReducerMapBuilder } from '@reduxjs/toolkit';
+import { selectConductorEnable } from 'src/features/conductor/flagConductorEnable';
+import { store } from 'src/pages/createStore';
 
 import { CodeOutput, InterpreterOutput } from '../../application/ApplicationTypes';
 import Constants from '../../utils/Constants';
@@ -103,6 +105,9 @@ export const handleReplActions = (builder: ActionReducerMapBuilder<WorkspaceMana
       state[workspaceLocation].replHistory.records = newReplHistoryRecords;
     })
     .addCase(WorkspaceActions.evalRepl, (state, action) => {
+      if (selectConductorEnable(store.getState())) {
+        return; // no-op: either we will already be running, or it will not start running
+      }
       const workspaceLocation = getWorkspaceLocation(action);
       state[workspaceLocation].isRunning = true;
     })

src/features/conductor/flagConductorEnable.ts

@@ -1,7 +1,10 @@
 import { createFeatureFlag } from 'src/commons/featureFlags';
+import { featureSelector } from 'src/commons/featureFlags/featureSelector';
 
 export const flagConductorEnable = createFeatureFlag(
   'conductor.enable',
   false,
   'Enables the Conductor framework for evaluation of user programs.'
 );
+
+export const selectConductorEnable = featureSelector(flagConductorEnable);