Skip to content

Commit 8dd4e5e

Browse files
remo5000ning-y
authored andcommitted
Use Grade instead of XP for AssessmentOverview (#239)
* Change maximumEXP -> maximumGrade * Update test
1 parent c7790dc commit 8dd4e5e

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/components/assessment/__tests__/__snapshots__/index.tsx.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ exports[`Assessment page with multiple loaded missions renders correctly 1`] = `
121121
</div>
122122
<div className=\\"row listing-order\\">
123123
<h6>
124-
XP: 3000
124+
Grade: 3000
125125
</h6>
126126
</div>
127127
<div className=\\"row listing-description\\">
@@ -190,7 +190,7 @@ exports[`Assessment page with multiple loaded missions renders correctly 1`] = `
190190
</div>
191191
<div className=\\"row listing-order\\">
192192
<h6>
193-
XP: 3000
193+
Grade: 3000
194194
</h6>
195195
</div>
196196
<div className=\\"row listing-description\\">
@@ -259,7 +259,7 @@ exports[`Assessment page with multiple loaded missions renders correctly 1`] = `
259259
</div>
260260
<div className=\\"row listing-order\\">
261261
<h6>
262-
XP: 3000
262+
Grade: 3000
263263
</h6>
264264
</div>
265265
<div className=\\"row listing-description\\">

src/components/assessment/assessmentShape.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export interface IAssessmentOverview {
77
closeAt: string
88
coverImage: string
99
id: number
10-
maximumEXP: number
10+
maximumGrade: number
1111
openAt: string
1212
shortSummary: string
1313
title: string

src/components/assessment/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ const makeOverviewCard = (overview: IAssessmentOverview, index: number) => (
161161
<h4>{overview.title}</h4>
162162
</div>
163163
<div className="row listing-order">
164-
<h6>{`XP: ${overview.maximumEXP}`}</h6>
164+
<h6>{`Grade: ${overview.maximumGrade}`}</h6>
165165
</div>
166166
<div className="row listing-description">
167167
<p className="col-xs-12">{overview.shortSummary}</p>

src/mocks/assessmentAPI.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const mockOpenAssessmentsOverviews: IAssessmentOverview[] = [
1616
closeAt: '2048-06-18T05:24:26.026Z',
1717
coverImage: 'www.imgur.com',
1818
id: 0,
19-
maximumEXP: 3000,
19+
maximumGrade: 3000,
2020
openAt: '2018-06-18T05:24:26.026Z',
2121
shortSummary:
2222
'Once upon a time, Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin nec vulputate sapien. Fusce vel lacus fermentum, efficitur ipsum.',
@@ -28,7 +28,7 @@ const mockOpenAssessmentsOverviews: IAssessmentOverview[] = [
2828
closeAt: '2048-06-18T05:24:26.026Z',
2929
coverImage: 'www.imgur.com',
3030
id: 1,
31-
maximumEXP: 3000,
31+
maximumGrade: 3000,
3232
openAt: '2018-07-18T05:24:26.026Z',
3333
shortSummary:
3434
'Once upon a time, Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin nec vulputate sapien. Fusce vel lacus fermentum, efficitur ipsum.',
@@ -40,7 +40,7 @@ const mockOpenAssessmentsOverviews: IAssessmentOverview[] = [
4040
closeAt: '2048-06-18T05:24:26.026Z',
4141
coverImage: 'www.imgur.com',
4242
id: 2,
43-
maximumEXP: 3000,
43+
maximumGrade: 3000,
4444
openAt: '2018-07-18T05:24:26.026Z',
4545
shortSummary:
4646
'Once upon a time, Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin nec vulputate sapien. Fusce vel lacus fermentum, efficitur ipsum.',
@@ -55,7 +55,7 @@ const mockClosedAssessmentOverviews: IAssessmentOverview[] = [
5555
closeAt: '2008-06-18T05:24:26.026Z',
5656
coverImage: 'www.imgur.com',
5757
id: 3,
58-
maximumEXP: 3000,
58+
maximumGrade: 3000,
5959
openAt: '2007-07-18T05:24:26.026Z',
6060
shortSummary:
6161
'Once upon a time, Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin nec vulputate sapien. Fusce vel lacus fermentum, efficitur ipsum.',
@@ -67,7 +67,7 @@ const mockClosedAssessmentOverviews: IAssessmentOverview[] = [
6767
closeAt: '2008-06-18T05:24:26.026Z',
6868
coverImage: 'www.imgur.com',
6969
id: 4,
70-
maximumEXP: 3000,
70+
maximumGrade: 3000,
7171
openAt: '2007-07-18T05:24:26.026Z',
7272
shortSummary:
7373
'Once upon a time, Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin nec vulputate sapien. Fusce vel lacus fermentum, efficitur ipsum.',

0 commit comments

Comments
 (0)