Skip to content

Commit b2c0843

Browse files
committed
fix linting errors
1 parent d4a30cb commit b2c0843

File tree

3 files changed

+30
-42
lines changed

3 files changed

+30
-42
lines changed

src/commons/application/Application.tsx

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
import React from 'react';
22
import { useDispatch } from 'react-redux';
33
import { Outlet } from 'react-router-dom';
4-
import Messages, { MessageType, MessageTypeNames, sendToWebview } from 'src/features/vscode/messages';
4+
import Messages, {
5+
MessageType,
6+
MessageTypeNames,
7+
sendToWebview
8+
} from 'src/features/vscode/messages';
59

610
import NavigationBar from '../navigationBar/NavigationBar';
711
import Constants from '../utils/Constants';
@@ -78,8 +82,8 @@ const Application: React.FC = () => {
7882
if (!window.confirm) {
7983
// Polyfill confirm() to instead show as VS Code notification
8084
// TODO: Pass text as a new Message to the webview
81-
window.confirm = (text) => {
82-
console.log(`Confirmation automatically accepted: ${text ?? "No text provided"}`);
85+
window.confirm = text => {
86+
console.log(`Confirmation automatically accepted: ${text ?? 'No text provided'}`);
8387
return true;
8488
};
8589
}
@@ -102,7 +106,12 @@ const Application: React.FC = () => {
102106
if (message.token) {
103107
const token = JSON.parse(message.token.trim());
104108
console.log(`FRONTEND: WebviewStarted: ${token}`);
105-
dispatch(SessionActions.setTokens({accessToken: token.accessToken, refreshToken: token.refreshToken}));
109+
dispatch(
110+
SessionActions.setTokens({
111+
accessToken: token.accessToken,
112+
refreshToken: token.refreshToken
113+
})
114+
);
106115
dispatch(SessionActions.fetchUserAndCourse());
107116
}
108117
break;
@@ -121,6 +130,7 @@ const Application: React.FC = () => {
121130
break;
122131
}
123132
});
133+
// eslint-disable-next-line react-hooks/exhaustive-deps
124134
}, []);
125135

126136
return (

src/commons/assessmentWorkspace/AssessmentWorkspace.tsx

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -215,27 +215,7 @@ const AssessmentWorkspace: React.FC<AssessmentWorkspaceProps> = props => {
215215
if (!assessment) {
216216
return;
217217
}
218-
// // ------------- PLEASE NOTE, EVERYTHING BELOW THIS SEEMS TO BE UNUSED -------------
219-
// // checkWorkspaceReset does exactly the same thing.
220-
// let questionId = props.questionId;
221-
// if (props.questionId >= assessment.questions.length) {
222-
// questionId = assessment.questions.length - 1;
223-
// }
224-
225-
// const question = assessment.questions[questionId];
226-
227-
// let answer = '';
228-
// if (question.type === QuestionTypes.programming) {
229-
// if (question.answer) {
230-
// answer = (question as IProgrammingQuestion).answer as string;
231-
// } else {
232-
// answer = (question as IProgrammingQuestion).solutionTemplate;
233-
// }
234-
// }
235-
236-
// // TODO: Hardcoded to make use of the first editor tab. Refactoring is needed for this workspace to enable Folder mode.
237-
// handleEditorValueChange(0, answer);
238-
// // eslint-disable-next-line react-hooks/exhaustive-deps
218+
// eslint-disable-next-line react-hooks/exhaustive-deps
239219
}, []);
240220

241221
/**

src/features/vscode/messages.ts

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ const Messages = createMessages({
1414
NewEditor: (assessmentName: string, questionId: number, code: string) => ({
1515
assessmentName,
1616
questionId,
17-
code,
17+
code
1818
}),
19-
Text: (code: string) => ({ code }),
19+
Text: (code: string) => ({ code })
2020
});
2121

2222
export default Messages;
@@ -32,20 +32,18 @@ type BaseMessage<T extends string, P extends object> = {
3232

3333
// A helper function to create messages dynamically from schema (hoisted!)
3434
function createMessages<T extends Record<string, (...args: any[]) => object>>(
35-
creators: T,
35+
creators: T
3636
): {
37-
[K in Extract<keyof T, string>]: (
38-
...args: Parameters<T[K]>
39-
) => BaseMessage<K, ReturnType<T[K]>>;
37+
[K in Extract<keyof T, string>]: (...args: Parameters<T[K]>) => BaseMessage<K, ReturnType<T[K]>>;
4038
} {
4139
return Object.fromEntries(
4240
Object.entries(creators).map(([key, creator]) => [
4341
key,
4442
(...args: any[]) => ({
4543
type: key,
46-
...creator(...args),
47-
}),
48-
]),
44+
...creator(...args)
45+
})
46+
])
4947
) as any;
5048
}
5149

@@ -61,14 +59,14 @@ export type MessageType = MessageTypes[keyof MessageTypes];
6159
export const MessageTypeNames = (() =>
6260
({
6361
...Object.keys(Messages)
64-
.filter((k) => isNaN(Number(k)))
62+
.filter(k => isNaN(Number(k)))
6563
.reduce(
6664
(acc, cur) => ({
6765
...acc,
68-
[cur]: cur,
66+
[cur]: cur
6967
}),
70-
{},
71-
),
68+
{}
69+
)
7270
}) as {
7371
[k in keyof typeof Messages]: k;
7472
})();
@@ -77,19 +75,19 @@ export const MessageTypeNames = (() =>
7775
// Wrapper functions
7876
// ================================================================================
7977

80-
export const FRONTEND_ELEMENT_ID = "frontend";
78+
export const FRONTEND_ELEMENT_ID = 'frontend';
8179

8280
export function sendToWebview(message: MessageType) {
83-
window.parent.postMessage(message, "*");
81+
window.parent.postMessage(message, '*');
8482
}
8583
export function sendToFrontend(document: Document, message: MessageType) {
8684
const iframe: HTMLIFrameElement = document.getElementById(
87-
FRONTEND_ELEMENT_ID,
85+
FRONTEND_ELEMENT_ID
8886
) as HTMLIFrameElement;
8987
const contentWindow = iframe.contentWindow;
9088
if (!contentWindow) {
9189
return;
9290
}
9391
// TODO: Don't hardcode this!
94-
contentWindow.postMessage(message, "http://localhost:8000");
92+
contentWindow.postMessage(message, 'http://localhost:8000');
9593
}

0 commit comments

Comments
 (0)