fix lint issues

Author: tsammeow

src/commons/application/ApplicationTypes.ts

@@ -7,6 +7,7 @@ import { PlaybackStatus, RecordingStatus } from '../../features/sourceRecorder/S
 import { StoriesEnvState, StoriesState } from '../../features/stories/StoriesTypes';
 import { freshSortState } from '../../pages/academy/grading/subcomponents/GradingSubmissionsTable';
 import { WORKSPACE_BASE_PATHS } from '../../pages/fileSystem/createInBrowserFileSystem';
+import { defaultFeatureFlags, FeatureFlagsState } from '../featureFlags';
 import { FileSystemState } from '../fileSystem/FileSystemTypes';
 import { SideContentManagerState, SideContentState } from '../sideContent/SideContentTypes';
 import Constants from '../utils/Constants';
@@ -20,7 +21,6 @@ import {
 import { RouterState } from './types/CommonsTypes';
 import { ExternalLibraryName } from './types/ExternalTypes';
 import { SessionState } from './types/SessionTypes';
-import { defaultFeatureFlags, FeatureFlagsState } from '../featureFlags';
 
 export type OverallState = {
   readonly router: RouterState;

src/commons/application/reducers/RootReducer.ts

@@ -1,11 +1,11 @@
 import { combineReducers, Reducer } from '@reduxjs/toolkit';
+import { FeatureFlagsReducer as featureFlags } from 'src/commons/featureFlags';
 import { SourceActionType } from 'src/commons/utils/ActionsHelper';
 
 import { AchievementReducer as achievement } from '../../../features/achievement/AchievementReducer';
 import { DashboardReducer as dashboard } from '../../../features/dashboard/DashboardReducer';
 import { PlaygroundReducer as playground } from '../../../features/playground/PlaygroundReducer';
 import { StoriesReducer as stories } from '../../../features/stories/StoriesReducer';
-import { FeatureFlagsReducer as featureFlags } from 'src/commons/featureFlags';
 import { FileSystemReducer as fileSystem } from '../../fileSystem/FileSystemReducer';
 import { SideContentReducer as sideContent } from '../../sideContent/SideContentReducer';
 import { WorkspaceReducer as workspaces } from '../../workspace/WorkspaceReducer';

src/commons/featureFlags/index.ts

@@ -1,4 +1,5 @@
 import { createSlice } from "@reduxjs/toolkit";
+
 import { FeatureFlag } from "./FeatureFlag";
 
 export type FeatureFlagsState = {
@@ -17,7 +18,7 @@ const featureFlagsSlice = createSlice({
             state.modifiedFlags[action.payload.featureFlag[0]] = action.payload.value;
         },
         resetFlag<T>(state: FeatureFlagsState, action: { payload: { featureFlag: FeatureFlag<T> } }) {
-            state.modifiedFlags[action.payload.featureFlag[0]];
+            delete state.modifiedFlags[action.payload.featureFlag[0]];
         }
     }
 });

src/commons/featureFlags/publicFlags.ts

@@ -1,4 +1,5 @@
 import { featureConductor } from "src/features/conductor/featureConductor";
+
 import { FeatureFlag } from "./FeatureFlag";
 
 export const publicFlags: FeatureFlag<any>[] = [

src/commons/featureFlags/selectFeature.ts

@@ -1,6 +1,7 @@
+import { SagaIterator } from "redux-saga";
 import { select } from "redux-saga/effects";
+
 import { FeatureFlag } from "./FeatureFlag";
-import { SagaIterator } from "redux-saga";
 
 export function* selectFeature<T>(featureFlag: FeatureFlag<T>): SagaIterator<T> {
     const [flag, defaultValue] = featureFlag;

src/commons/featureFlags/useFeature.ts

@@ -1,9 +1,8 @@
-import { useSelector } from "react-redux";
-import { OverallState } from "../application/ApplicationTypes";
+import { useTypedSelector } from "../utils/Hooks";
 import { FeatureFlag } from "./FeatureFlag";
 
 export function useFeature<T>(featureFlag: FeatureFlag<T>) {
     const [flag, defaultValue] = featureFlag;
-    const flagValue = useSelector<OverallState, T | undefined>(state => state.featureFlags.modifiedFlags[flag]);
+    const flagValue = useTypedSelector(state => state.featureFlags.modifiedFlags[flag]);
     return flagValue ?? defaultValue;
 }

src/commons/mocks/StoreMocks.ts

@@ -14,9 +14,9 @@ import {
   defaultWorkspaceManager,
   OverallState
 } from '../application/ApplicationTypes';
+import { defaultFeatureFlags } from '../featureFlags';
 import { SourceActionType } from '../utils/ActionsHelper';
 import { DeepPartial } from '../utils/TypeHelper';
-import { defaultFeatureFlags } from '../featureFlags';
 
 export function mockInitialStore(
   overrides?: DeepPartial<OverallState>

src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts

@@ -7,10 +7,15 @@ import { manualToggleDebugger } from 'js-slang/dist/stdlib/inspector';
 import { Chapter, ErrorSeverity, ErrorType, SourceError, Variant } from 'js-slang/dist/types';
 import { eventChannel, SagaIterator } from 'redux-saga';
 import { call, cancel, cancelled, delay, fork, put, race, select, take } from 'redux-saga/effects';
+import { IConduit } from 'sa-conductor/dist/conduit';
 import * as Sourceror from 'sourceror';
 import InterpreterActions from 'src/commons/application/actions/InterpreterActions';
+import { selectFeature } from 'src/commons/featureFlags/selectFeature';
 import { makeCCompilerConfig, specialCReturnObject } from 'src/commons/utils/CToWasmHelper';
 import { javaRun } from 'src/commons/utils/JavaHelper';
+import { BrowserHostPlugin } from 'src/features/conductor/BrowserHostPlugin';
+import { createConductor } from 'src/features/conductor/createConductor';
+import { featureConductor } from 'src/features/conductor/featureConductor';
 import StoriesActions from 'src/features/stories/StoriesActions';
 
 import { EventType } from '../../../../features/achievement/AchievementTypes';
@@ -29,11 +34,6 @@ import {
 } from '../../../workspace/WorkspaceTypes';
 import { dumpDisplayBuffer } from './dumpDisplayBuffer';
 import { updateInspector } from './updateInspector';
-import { createConductor } from 'src/features/conductor/createConductor';
-import { IConduit } from 'sa-conductor/dist/conduit';
-import { BrowserHostPlugin } from 'src/features/conductor/BrowserHostPlugin';
-import { featureConductor } from 'src/features/conductor/featureConductor';
-import { selectFeature } from 'src/commons/featureFlags/selectFeature';
 
 export function* evalCodeSaga(
   files: Record<string, string>,

src/features/conductor/createConductor.ts

@@ -1,4 +1,5 @@
 import { Conduit, IConduit } from "sa-conductor/dist/conduit";
+
 import { BrowserHostPlugin } from "./BrowserHostPlugin";
 
 export function createConductor(evaluatorPath: string, onRequestFile: (fileName: string) => Promise<string | undefined>): { hostPlugin: BrowserHostPlugin, conduit: IConduit } {