Add more tests

Author: leeyi45

src/commons/redux/__tests__/utils.ts

@@ -1,7 +1,7 @@
 import { testSaga } from "redux-saga-test-plan"
 import WorkspaceActions from "src/commons/workspace/WorkspaceActions"
 
-import { combineSagaHandlers } from "../utils"
+import { combineSagaHandlers, createActions } from "../utils"
 
 // Would have used spyOn, but for some reason that doesn't work properly
 jest.mock('src/commons/sagas/SafeEffects', () => ({
@@ -26,6 +26,10 @@ test('test combineSagaHandlers', () => {
     },
     [WorkspaceActions.toggleUsingSubst.type]: {
       takeLeading: mockTakeLeadingHandler
+    },
+    [WorkspaceActions.toggleEditorAutorun.type]: {
+      takeEvery: mockTakeEveryHandler,
+      takeLeading: mockTakeLeadingHandler
     }
   })
 
@@ -39,5 +43,27 @@ test('test combineSagaHandlers', () => {
     .next()
     .takeLeading(WorkspaceActions.toggleUsingSubst.type, mockTakeLeadingHandler)
     .next()
+    .takeEvery(WorkspaceActions.toggleEditorAutorun.type, mockTakeEveryHandler)
+    .next()
+    .takeLeading(WorkspaceActions.toggleEditorAutorun.type, mockTakeLeadingHandler)
+    .next()
     .isDone()
 })
+
+test('createActions', () => {
+  const actions = createActions('workspace', {
+    act0: false,
+    act1: (value: string) => ({ value }),
+    act2: 525600
+  })
+
+  const act0 = actions.act0()
+  expect(act0.type).toEqual('workspace/act0')
+
+  const act1 = actions.act1('test')
+  expect(act1.type).toEqual('workspace/act1')
+  expect(act1.payload).toMatchObject({ value: 'test' })
+
+  const act2 = actions.act2()
+  expect(act2.type).toEqual('workspace/act2')
+})

src/commons/redux/utils.ts

@@ -14,7 +14,7 @@ import { type ActionTypeToCreator, objectEntries } from '../utils/TypeHelper';
 /**
  * Creates actions, given a base name and base actions
  * @param baseName The base name of the actions
- * @param baseActions The base actions. Use a falsy value to create an action without a payload.
+ * @param baseActions The base actions. Use a non function value to create an action without a payload.
  * @returns An object containing the actions
  */
 export function createActions<BaseName extends string, BaseActions extends Record<string, any>>(
@@ -24,7 +24,7 @@ export function createActions<BaseName extends string, BaseActions extends Recor
   return Object.entries(baseActions).reduce(
     (res, [name, func]) => ({
       ...res,
-      [name]: func
+      [name]: typeof func === 'function'
         ? createAction(`${baseName}/${name}`, (...args: any) => ({ payload: func(...args) }))
         : createAction(`${baseName}/${name}`)
     }),

src/commons/sagas/__tests__/SafeEffects.ts

@@ -0,0 +1,35 @@
+import * as Sentry from '@sentry/browser'
+import { call } from "redux-saga/effects"
+import { expectSaga } from "redux-saga-test-plan"
+
+import { wrapSaga } from "../SafeEffects"
+
+jest.spyOn(Sentry, 'captureException')
+
+// Silence console error
+jest.spyOn(console, 'error').mockImplementation(x => {})
+
+describe('Test wrapSaga', () => {
+  test('wrapSaga is transparent', async () => {
+    const mockFn = jest.fn()
+    const wrappedSaga = wrapSaga(function* () {
+      yield call(mockFn)
+    })
+
+    await expectSaga(wrappedSaga).silentRun()
+
+    expect(mockFn).toHaveBeenCalledTimes(1)
+  })
+
+  test('wrapSaga handles errors appropriately', async () => {
+    const errorToThrow = new Error()
+    const wrappedSaga = wrapSaga(function* () {
+      throw errorToThrow
+    })
+
+    await expectSaga(wrappedSaga).silentRun()
+
+    expect(Sentry.captureException).toHaveBeenCalledWith(errorToThrow)
+    expect(console.error).toHaveBeenCalledTimes(1)
+  })
+})