Skip to content

Commit cc9ddac

Browse files
committed
Remove action and reducer to get all users for overall leaderboards
1 parent ea1fdfd commit cc9ddac

File tree

4 files changed

+5
-19
lines changed

4 files changed

+5
-19
lines changed

src/commons/sagas/LeaderboardSaga.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,12 @@ import { actions } from '../utils/ActionsHelper';
77
import { selectTokens } from './BackendSaga';
88
import {
99
getAllContests,
10-
getAllTotalXp,
1110
getContestPopularVoteLeaderboard,
1211
getContestScoreLeaderboard,
1312
getPaginatedTotalXp
1413
} from './RequestsSaga';
1514

1615
const LeaderboardSaga = combineSagaHandlers({
17-
[LeaderboardActions.getAllUsersXp.type]: function* () {
18-
const tokens: Tokens = yield selectTokens();
19-
20-
const usersXp = yield call(getAllTotalXp, tokens);
21-
22-
if (usersXp) {
23-
yield put(actions.saveAllUsersXp(usersXp));
24-
}
25-
},
26-
2716
[LeaderboardActions.getPaginatedLeaderboardXp.type]: function* (action) {
2817
const tokens: Tokens = yield selectTokens();
2918
const { page, pageSize } = action.payload;

src/commons/sagas/RequestsSaga.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -463,10 +463,12 @@ export const getTotalXp = async (tokens: Tokens, courseRegId?: number): Promise<
463463
};
464464

465465
/**
466-
* GET /courses/{courseId}/all_user_xp
466+
* GET /courses/{courseId}/leaderboards/xp_all
467467
*/
468-
export const getAllTotalXp = async (tokens: Tokens): Promise<number | null> => {
469-
const resp = await request(`${courseId()}/all_users_xp`, 'GET', {
468+
export const getAllOverallLeaderboardXP = async (
469+
tokens: Tokens
470+
): Promise<LeaderboardRow[] | null> => {
471+
const resp = await request(`${courseId()}/leaderboards/xp_all`, 'GET', {
470472
...tokens
471473
});
472474

src/features/leaderboard/LeaderboardActions.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {
77
} from './LeaderboardTypes';
88

99
const LeaderboardActions = createActions('leaderboard', {
10-
getAllUsersXp: 0,
11-
saveAllUsersXp: (userXp: LeaderboardRow[]) => userXp,
1210
getPaginatedLeaderboardXp: (page: number, pageSize: number) => ({ page, pageSize }),
1311
savePaginatedLeaderboardXp: (payload: { rows: LeaderboardRow[]; userCount: number }) => payload,
1412
getAllContestScores: (assessmentId: number, visibleEntries: number) => ({

src/features/leaderboard/LeaderboardReducer.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ export const LeaderboardReducer: Reducer<LeaderboardState, SourceActionType> = c
99
defaultLeaderboard,
1010
builder => {
1111
builder
12-
.addCase(LeaderboardActions.saveAllUsersXp, (state, action) => {
13-
state.userXp = action.payload;
14-
})
1512
.addCase(LeaderboardActions.savePaginatedLeaderboardXp, (state, action) => {
1613
state.paginatedUserXp = {
1714
rows: action.payload.rows || [],

0 commit comments

Comments
 (0)