Fix ace editor warnings in test suite by addressing webpack issue #2982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8935791080Details
💛 - Coveralls |
RichDom2185
approved these changes
May 3, 2024
Member
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
LGTM, thanks! I'll rebase my changes in #2905 following this merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes console warnings in test suite. Issue arises in testing environment due to
ace/webpack-resolver, which results in the ace module paths not being found at test time.This PR manually resolves the webpack issues instead of relying on the cryptic
ace/webpack-resolver.Closes #2962
Type of change
How to test
Test suite should no longer display ace editor warnings
Checklist