Skip to content

Conversation

@heyzec
Copy link
Contributor

@heyzec heyzec commented Jun 26, 2025

Description

This PR is needed for the following:

Features:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

renovate bot and others added 29 commits June 16, 2025 17:17
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
by not sending Text messages from frontend to VSC
- New MCQQuestion message type
This reverts commit 18c4597.
Remove the question description from the McqQuestion payload as it is
not used.
@heyzec heyzec requested a review from sayomaki June 26, 2025 09:59
@heyzec
Copy link
Contributor Author

heyzec commented Jun 28, 2025

Unfortunately, the changes with deps on master has made the tests fail, this may take a while

@coveralls
Copy link

coveralls commented Jun 28, 2025

Pull Request Test Coverage Report for Build 15941719322

Details

  • 42 of 63 (66.67%) changed or added relevant lines in 7 files are covered.
  • 179 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.07%) to 44.721%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/assessment/Assessment.tsx 11 12 91.67%
src/commons/assessmentWorkspace/AssessmentWorkspace.tsx 6 7 85.71%
src/pages/playground/Playground.tsx 5 7 71.43%
src/commons/application/Application.tsx 8 11 72.73%
src/pages/academy/game/Game.tsx 0 4 0.0%
src/features/vscode/messages.ts 10 20 50.0%
Files with Coverage Reduction New Missed Lines %
src/commons/workspace/WorkspaceActions.ts 2 72.97%
src/pages/academy/game/Game.tsx 3 0.0%
src/features/vscode/messages.ts 6 47.22%
src/commons/workspace/reducers/editorReducer.ts 7 93.84%
src/commons/application/Application.tsx 17 35.98%
src/commons/assessment/Assessment.tsx 17 78.41%
src/commons/assessmentWorkspace/AssessmentWorkspace.tsx 57 69.2%
src/pages/playground/Playground.tsx 70 62.55%
Totals Coverage Status
Change from base Build 15938654153: 0.07%
Covered Lines: 10103
Relevant Lines: 21173

💛 - Coveralls


useEffect(() => {
if (assessmentOverviewsUnfiltered && courseId) {
sendToWebview(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this why we are sending everything (including upcoming ones)? Looks good for now but can always make this minor change in the future.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 16386df into master Jun 28, 2025
9 checks passed
@RichDom2185 RichDom2185 deleted the vscode/next branch June 28, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants