Skip to content

Conversation

@heyzec
Copy link
Contributor

@heyzec heyzec commented Jun 30, 2025

Description

Fixup to #3201

I forgot to add this redirect, otherwise in the webview, the login spinner appears and the user has to do one more click to view courses.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) June 30, 2025 15:56
@RichDom2185 RichDom2185 merged commit 7d7870a into master Jun 30, 2025
9 checks passed
@RichDom2185 RichDom2185 deleted the vscode/oauth branch June 30, 2025 15:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15977726459

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 44.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/login/LoginVscodeCallback.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/login/LoginVscodeCallback.tsx 5 0.0%
Totals Coverage Status
Change from base Build 15956924756: -0.006%
Covered Lines: 10109
Relevant Lines: 21218

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants