From d3b44d38962eb141043fed6c914e39cf9ac2bd5e Mon Sep 17 00:00:00 2001 From: sayomaki Date: Wed, 3 Sep 2025 01:29:10 +0800 Subject: [PATCH 1/2] Add function to parse display name for the assessment --- .../subcomponents/GradingWorkspace.tsx | 23 +++++++++++++++---- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx b/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx index 7cbdbd1a1f..0d7d9a50b6 100644 --- a/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx +++ b/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx @@ -53,6 +53,20 @@ type Props = { questionId: number; }; +const getDisplayName = ( + studentName?: string | null, + team?: { + username: any; + name: string; + id: number; + }[] +): string[] => { + if (studentName != null) return [studentName]; + if (team != null) return team.map(member => member.name); + + return ['']; +}; + const GradingWorkspace: React.FC = props => { const navigate = useNavigate(); const { selectedTab, setSelectedTab } = useSideContent( @@ -294,11 +308,10 @@ const GradingWorkspace: React.FC = props => { initialXp={grading!.answers[questionId].grade.xp} xpAdjustment={grading!.answers[questionId].grade.xpAdjustment} maxXp={grading!.answers[questionId].question.maxXp} - studentNames={ - grading!.answers[questionId].student.name - ? [grading!.answers[questionId].student.name] - : grading!.answers[questionId].team!.map(member => member.name) - } + studentNames={getDisplayName( + grading!.answers[questionId].student.name, + grading!.answers[questionId].team + )} studentUsernames={ grading!.answers[questionId].student.username ? [grading!.answers[questionId].student.username] From 50c01ad49c73422b26ef18ef2927112fd736612b Mon Sep 17 00:00:00 2001 From: sayomaki Date: Wed, 3 Sep 2025 01:33:29 +0800 Subject: [PATCH 2/2] Retain original check for studentName --- src/pages/academy/grading/subcomponents/GradingWorkspace.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx b/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx index 0d7d9a50b6..b9a11c13db 100644 --- a/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx +++ b/src/pages/academy/grading/subcomponents/GradingWorkspace.tsx @@ -61,7 +61,7 @@ const getDisplayName = ( id: number; }[] ): string[] => { - if (studentName != null) return [studentName]; + if (studentName) return [studentName]; if (team != null) return team.map(member => member.name); return [''];