Fix more type errors

Author: RichDom2185

src/editors/ace/modes/source.ts

@@ -37,7 +37,7 @@ export function HighlightRulesSelector(
       }
   )[] = []
 ) {
-  // @ts-ignore
+  // @ts-expect-error implicit any
   function _SourceHighlightRules(acequire, exports, _module) {
     'use strict'
 
@@ -49,7 +49,8 @@ export function HighlightRulesSelector(
     const identifierRegex = '[a-zA-Z\\$_\u00a1-\uffff][a-zA-Z\\d\\$_\u00a1-\uffff]*'
 
     const chapter = variant === Variant.DEFAULT ? id.toString() : id.toString() + '_' + variant
-    const builtin_lib = SourceDocumentation.builtins[chapter]
+    const builtin_lib =
+      SourceDocumentation.builtins[chapter as keyof typeof SourceDocumentation.builtins]
 
     function addFromBuiltinLibrary(meta: string) {
       if (builtin_lib === null) {

src/parser/__tests__/disallowed-syntax.ts

@@ -446,7 +446,7 @@ test('Cannot use function expressions', () => {
     stripIndent`
     (function fib(x) { return x <= 1 ? x : fib(x-1) + fib(x-2); })(4);
     `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`"Line 1: Function expressions are not allowed"`)
 })
 
@@ -456,7 +456,7 @@ test('Cannot use function expressions - verbose', () => {
     "enable verbose";
     (function fib(x) { return x <= 1 ? x : fib(x-1) + fib(x-2); })(4);
     `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`
             "Line 2, Column 1: Function expressions are not allowed
             You are trying to use Function expressions, which is not allowed (yet).
@@ -469,7 +469,7 @@ test('Cannot use function expressions', () => {
     stripIndent`
     (function(x) { return x + 1; })(4);
     `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`"Line 1: Function expressions are not allowed"`)
 })
 
@@ -479,7 +479,7 @@ test('Cannot use function expressions - verbose', () => {
     "enable verbose";
     (function(x) { return x + 1; })(4);
     `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`
             "Line 2, Column 1: Function expressions are not allowed
             You are trying to use Function expressions, which is not allowed (yet).
@@ -852,7 +852,7 @@ test('No classes', () => {
     class Box {
     }
     `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`
             "Line 1: Class bodys are not allowed
             Line 1: Class declarations are not allowed"
@@ -866,7 +866,7 @@ test('No classes - verbose', () => {
     class Box {
     }
     `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`
             "Line 2, Column 10: Class bodys are not allowed
             You are trying to use Class bodys, which is not allowed (yet).
@@ -886,7 +886,7 @@ test('No super', () => {
       }
     }
     `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`
             "Line 3: Supers are not allowed
             Line 2: Function expressions are not allowed
@@ -906,7 +906,7 @@ test('No super - verbose', () => {
       }
     }
   `,
-    { chapter: 5 }
+    { chapter: 5 as Chapter }
   ).toMatchInlineSnapshot(`
             "Line 4, Column 4: Supers are not allowed
             You are trying to use Supers, which is not allowed (yet).

src/parser/source/typed/typeParser.ts

@@ -395,7 +395,7 @@ const tsPlugin = (BaseParser: any) => {
       let node
       switch (this.type) {
         case tokTypes.name:
-          switch (tsTypeOperator[this.value]) {
+          switch (tsTypeOperator[this.value as keyof typeof tsTypeOperator]) {
             case tsTypeOperator.infer:
               node = this.parseTSInferType()
               break
@@ -431,7 +431,7 @@ const tsPlugin = (BaseParser: any) => {
     }
 
     _parseTSDeclaration(node: any, expr: { name: string | number }) {
-      const val = tsDeclaration[expr.name]
+      const val = tsDeclaration[expr.name as keyof typeof tsDeclaration]
       switch (val) {
         case tsDeclaration.interface:
           if (this.type === tokTypes.name) {
@@ -467,7 +467,7 @@ const tsPlugin = (BaseParser: any) => {
       const node = this.startNode()
       const keyword = this.value
       this.next()
-      this.finishNode(node, tsPredefinedType[keyword])
+      this.finishNode(node, tsPredefinedType[keyword as keyof typeof tsPredefinedType])
       return node
     }
 
@@ -1028,18 +1028,27 @@ const tsPlugin = (BaseParser: any) => {
     }
 
     _parseMaybeTSExpression(node: any) {
-      if (this.type === tokTypes.prefix && tsExprMarkup[this.value] === tsExprMarkup['!']) {
+      if (
+        this.type === tokTypes.prefix &&
+        tsExprMarkup[this.value as keyof typeof tsExprMarkup] === tsExprMarkup['!']
+      ) {
         node = this.parseTSNonNullExpression(node)
       }
-      if (this.type === tokTypes.name && tsExprMarkup[this.value] === tsExprMarkup.as) {
+      if (
+        this.type === tokTypes.name &&
+        tsExprMarkup[this.value as keyof typeof tsExprMarkup] === tsExprMarkup.as
+      ) {
         node = this.parseTSAsExpression(node)
       }
       return node
     }
 
     parseTSAsExpression(expression: any) {
       let node = expression
-      while (this.type === tokTypes.name && tsExprMarkup[this.value] === tsExprMarkup.as) {
+      while (
+        this.type === tokTypes.name &&
+        tsExprMarkup[this.value as keyof typeof tsExprMarkup] === tsExprMarkup.as
+      ) {
         const _node = this.startNodeAtNode(node)
         this.next()
         _node.expression = node
@@ -1051,7 +1060,10 @@ const tsPlugin = (BaseParser: any) => {
 
     parseTSNonNullExpression(expression: any) {
       let node = expression
-      while (this.type === tokTypes.prefix && tsExprMarkup[this.value] === tsExprMarkup['!']) {
+      while (
+        this.type === tokTypes.prefix &&
+        tsExprMarkup[this.value as keyof typeof tsExprMarkup] === tsExprMarkup['!']
+      ) {
         const _node = this.startNodeAtNode(node)
         _node.expression = node
         this.next()

src/stepper/converter.ts

@@ -79,9 +79,10 @@ function evaluateFunctionObject(node: substituterNodes, context: Context) {
     if (node.type === 'Identifier' && builtinFunctions[node.name]) {
       ;(global as any)[node.name] = builtinFunctions[node.name]
     }
-    for (const key in node) {
-      if (node[key as keyof typeof node] && typeof node[key as keyof typeof node] === 'object') {
-        lookUpIdentifiers(node[key as keyof typeof node] as unknown as substituterNodes, visited)
+    for (const k in node) {
+      const key = k as keyof typeof node
+      if (node[key] && typeof node[key] === 'object') {
+        lookUpIdentifiers(node[key] as unknown as substituterNodes, visited)
       }
     }
   }

src/transpiler/transpiler.ts

@@ -7,6 +7,7 @@ import { NATIVE_STORAGE_ID, UNKNOWN_LOCATION } from '../constants'
 import { Chapter, type Context, type NativeStorage, type Node, Variant } from '../types'
 import * as create from '../utils/ast/astCreator'
 import { filterImportDeclarations, getImportedName } from '../utils/ast/helpers'
+import { isNamespaceSpecifier } from '../utils/ast/typeGuards'
 import {
   getFunctionDeclarationNamesInProgram,
   getIdentifiersInNativeStorage,
@@ -17,7 +18,6 @@ import {
 } from '../utils/uniqueIds'
 import { simple } from '../utils/walkers'
 import { checkForUndefinedVariables } from '../validator/validator'
-import { isNamespaceSpecifier } from '../utils/ast/typeGuards'
 
 /**
  * This whole transpiler includes many many many many hacks to get stuff working.

src/utils/uniqueIds.ts

@@ -20,7 +20,7 @@ const globalIdNames = [
 export type NativeIds = Record<(typeof globalIdNames)[number], es.Identifier>
 
 export function getNativeIds(program: es.Program, usedIdentifiers: Set<string>): NativeIds {
-  const globalIds = {}
+  const globalIds: Partial<NativeIds> = {}
   for (const identifier of globalIdNames) {
     globalIds[identifier] = create.identifier(getUniqueId(usedIdentifiers, identifier))
   }