Fix test utils not correctly handling snapshot names

Author: leeyi45

src/utils/testing/__tests__/testing.ts

@@ -56,43 +56,6 @@ describe('Testing createTestContext', () => {
   })
 })
 
-describe('Extra test results', () => {
-  test('Test context contains the extra results', () => {
-    const context = createTestContext()
-    expect('displayResult' in context).toEqual(true)
-    expect('alertResult' in context).toEqual(true)
-    expect('visualiseListResult' in context).toEqual(true)
-    expect('promptResult' in context).toEqual(true)
-  })
-
-  test('Calling display actually adds to displayResult', async () => {
-    const { context } = await testSuccess(`display("hi"); display("bye");`)
-    expect(context.displayResult).toMatchObject(['"hi"', '"bye"'])
-  })
-
-  test('Calling alert actually adds to alertResult', async () => {
-    const { context } = await testSuccess(`alert("hi"); alert("bye");`, Chapter.LIBRARY_PARSER)
-    expect(context.alertResult).toMatchObject(['hi', 'bye'])
-  })
-
-  test('Calling draw_data actually adds to visualizeList', async () => {
-    const { context } = await testSuccess(`draw_data(list(1, 2));`, Chapter.SOURCE_2)
-    expect(context.visualiseListResult).toMatchInlineSnapshot(`
-Array [
-  Array [
-    Array [
-      1,
-      Array [
-        2,
-        null,
-      ],
-    ],
-  ],
-]
-`)
-  })
-})
-
 describe('Test testing functions', () => {
   test('Test testSuccess resolves on evaluation success', () => {
     asMockedFunc(main.runInContext).mockResolvedValueOnce({
@@ -130,3 +93,40 @@ describe('Test testing functions', () => {
     return expect(testFailure('')).rejects.toThrow()
   })
 })
+
+describe('Extra test results', () => {
+  test('Test context contains the extra results', () => {
+    const context = createTestContext()
+    expect('displayResult' in context).toEqual(true)
+    expect('alertResult' in context).toEqual(true)
+    expect('visualiseListResult' in context).toEqual(true)
+    expect('promptResult' in context).toEqual(true)
+  })
+
+  test('Calling display actually adds to displayResult', async () => {
+    const { context } = await testSuccess(`display("hi"); display("bye");`)
+    expect(context.displayResult).toMatchObject(['"hi"', '"bye"'])
+  })
+
+  test('Calling alert actually adds to alertResult', async () => {
+    const { context } = await testSuccess(`alert("hi"); alert("bye");`, Chapter.LIBRARY_PARSER)
+    expect(context.alertResult).toMatchObject(['hi', 'bye'])
+  })
+
+  test('Calling draw_data actually adds to visualizeList', async () => {
+    const { context } = await testSuccess(`draw_data(list(1, 2));`, Chapter.SOURCE_2)
+    expect(context.visualiseListResult).toMatchInlineSnapshot(`
+Array [
+  Array [
+    Array [
+      1,
+      Array [
+        2,
+        null,
+      ],
+    ],
+  ],
+]
+`)
+  })
+})

src/utils/testing/index.ts

@@ -132,7 +132,11 @@ export async function expectNativeToTimeoutAndError(code: string, timeout: numbe
  */
 export async function snapshotSuccess(code: string, options: TestOptions = {}, name?: string) {
   const results = await testSuccess(code, options)
-  expect(results).toMatchSnapshot(name)
+  if (name === undefined) {
+    expect(results).toMatchSnapshot()
+  } else {
+    expect(results).toMatchSnapshot(name)
+  }
   return results
 }
 
@@ -141,7 +145,11 @@ export async function snapshotSuccess(code: string, options: TestOptions = {}, n
  */
 export async function snapshotFailure(code: string, options: TestOptions = {}, name?: string) {
   const results = await testFailure(code, options)
-  expect(results).toMatchSnapshot(name)
+  if (name === undefined) {
+    expect(results).toMatchSnapshot()
+  } else {
+    expect(results).toMatchSnapshot(name)
+  }
   return results
 }