Add explicit type for argument externals (#18)

remo5000 · ning-y · commit b0c4f6fcdb42 · 2018-07-13T17:55:37.000+08:00
diff --git a/src/createContext.ts b/src/createContext.ts
@@ -154,7 +154,7 @@ const defaultBuiltIns: CustomBuiltIns = {
     throw new Error('List visualizer is not enabled')}
 }
 
-const createContext = <T>(chapter = 1, externals = [], externalContext?: T, 
+const createContext = <T>(chapter = 1, externals: string[] = [], externalContext?: T, 
   externalBuiltIns: CustomBuiltIns = defaultBuiltIns) => {
   const context = createEmptyContext(chapter, externalContext)
 

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ const defaultBuiltIns: CustomBuiltIns = {`
`154`	`154`	`throw new Error('List visualizer is not enabled')}`
`155`	`155`	`}`
`156`	`156`
`157`		`-const createContext = <T>(chapter = 1, externals = [], externalContext?: T,`
	`157`	`+const createContext = <T>(chapter = 1, externals: string[] = [], externalContext?: T,`
`158`	`158`	`externalBuiltIns: CustomBuiltIns = defaultBuiltIns) => {`
`159`	`159`	`const context = createEmptyContext(chapter, externalContext)`
`160`	`160`