Fix for JSON imports not working #1752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the original comment in the commit 80341a9, the 3 year long issue still holds right now as described by the comment itself. It appears that the compiled version (using
yarn build) will append thedefaultkey to the imported JSON files, which does not exist and hence giving an error when used by other project (i.e. frontend). However, it does work correctly in testing/jest which appears to usets-jestinstead to transpile the typescript files.This PR reverts the commit added here: bca2423
Some other possible fixes for this that can be considered (but more testing and discussion required):
tscinstead ofts-jest(mentioned briefly on the jest docs, but this may affect coverage reporting/results)Type of change
Checklist