Skip to content

Conversation

@s-kybound
Copy link
Member

Description

The current version of js-slang is not usable as a command line tool due to a malformed shebang. This is the first of several fixes to investigate the stability of js-slang as a headless tool

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How to test

  • build js-slang
  • attempt to run it as a CLI tool

Checklist

  • I have tested this code

@s-kybound s-kybound requested a review from martin-henz August 15, 2025 17:00
@s-kybound s-kybound added Bug Something isn't working critical Fixing this is mission-critical labels Aug 15, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16995023277

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.062%

Totals Coverage Status
Change from base Build 16938519378: 0.0%
Covered Lines: 10100
Relevant Lines: 12737

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was thinking of migrating to tsup to get ESM+CJS dual package to make it easy for both CLI and browser use cases

@RichDom2185 RichDom2185 merged commit f92811f into master Aug 15, 2025
5 checks passed
@RichDom2185 RichDom2185 deleted the kyriel/fixREPL branch August 15, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working critical Fixing this is mission-critical

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants