Skip to content

Commit 10c2591

Browse files
committed
Revert to old coverage reporter
1 parent a09707a commit 10c2591

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

lib/modules-lib/src/types/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export abstract class glAnimation {
1919

2020
public abstract getFrame(timestamp: number): AnimFrame;
2121

22-
public static isAnimation = (obj: any): obj is glAnimation => obj.fps !== undefined;
22+
public static isAnimation = (obj: any): obj is glAnimation => obj instanceof glAnimation;
2323
}
2424
export interface AnimFrame {
2525
draw: (canvas: HTMLCanvasElement) => void;

lib/vitest-reporter/src/__tests__/coverage.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ describe(CoverageReporter, () => {
2929
}
3030
});
3131

32-
it('doesn\'t open the summary file if GITHUB_STEP_SUMMARY isn\'t defined', ({ reporter }) => {
33-
reporter.onStart({} as any, { watermarks: {} } as any);
34-
expect(fs.createWriteStream).not.toHaveBeenCalled();
32+
it.skipIf(!!process.env.GITHUB_STEP_SUMMARY)('doesn\'t open the summary file if GITHUB_STEP_SUMMARY isn\'t defined', ({ reporter }) => {
33+
reporter.onStart({} as any, { watermarks: {} } as any);
34+
expect(fs.createWriteStream).not.toHaveBeenCalled();
3535
});
3636
});

lib/vitest-reporter/src/__tests__/test-reporter.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ describe(TestReporter, () => {
2626
}
2727
});
2828

29-
it('doesn\'t open the summary file if GITHUB_STEP_SUMMARY isn\'t defined', ({ reporter }) => {
29+
it.skipIf(!!process.env.GITHUB_STEP_SUMMARY)('doesn\'t open the summary file if GITHUB_STEP_SUMMARY isn\'t defined', ({ reporter }) => {
3030
reporter.onInit();
3131
expect(fs.createWriteStream).not.toHaveBeenCalled();
3232
});

src/bundles/rune/src/functions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ export class HollusionRune extends DrawnRune {
650650
}
651651

652652
/** @hidden */
653-
export const isHollusionRune = (rune: DrawnRune): rune is HollusionRune => rune.isHollusion;
653+
export const isHollusionRune = (rune: DrawnRune): rune is HollusionRune => rune instanceof HollusionRune;
654654

655655
/**
656656
* Makes a new Rune from two given Runes by

0 commit comments

Comments
 (0)