Skip to content

Commit 12da06a

Browse files
committed
Fix bundles and tabs package not being handled correctly
1 parent 15c3d41 commit 12da06a

File tree

1 file changed

+31
-29
lines changed

1 file changed

+31
-29
lines changed

.github/actions/src/info/index.ts

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -164,38 +164,40 @@ function rawRecordToFullRecord(
164164
package: { devDependencies }
165165
}: RawPackageRecord<boolean>
166166
): PackageRecord {
167-
const match = packageNameRE.exec(packageName);
168-
if (!match) throw new Error(`Unknown package ${packageName}`);
169-
170-
const [, packageType, baseName] = match;
171167
const needsPlaywright = !!devDependencies && 'playwright' in devDependencies;
172168

173-
switch (packageType) {
174-
case 'bundle':
175-
return {
176-
changes: hasChanges,
177-
directory: directory,
178-
name: packageName,
179-
needsPlaywright,
180-
bundleName: baseName,
181-
};
182-
case 'tab':
183-
return {
184-
changes: hasChanges,
185-
directory: directory,
186-
name: packageName,
187-
needsPlaywright,
188-
tabName: baseName,
189-
};
190-
191-
default:
192-
return {
193-
changes: hasChanges,
194-
directory: directory,
195-
name: packageName,
196-
needsPlaywright
197-
};
169+
if (packageName !== '@sourceacademy/bundles' && packageName !== '@sourceacademy/tabs') {
170+
const match = packageNameRE.exec(packageName);
171+
if (!match) throw new Error(`Unknown package ${packageName}`);
172+
173+
const [, packageType, baseName] = match;
174+
175+
switch (packageType) {
176+
case 'bundle':
177+
return {
178+
changes: hasChanges,
179+
directory: directory,
180+
name: packageName,
181+
needsPlaywright,
182+
bundleName: baseName,
183+
};
184+
case 'tab':
185+
return {
186+
changes: hasChanges,
187+
directory: directory,
188+
name: packageName,
189+
needsPlaywright,
190+
tabName: baseName,
191+
};
192+
}
198193
}
194+
195+
return {
196+
changes: hasChanges,
197+
directory: directory,
198+
name: packageName,
199+
needsPlaywright
200+
};
199201
}
200202

201203
/**

0 commit comments

Comments
 (0)