Add missing repotools tests

Author: leeyi45

eslint.config.js

@@ -87,7 +87,6 @@ export default tseslint.config(
         'always',
         { markers: todoTreeKeywordsAll }
       ],
-
     }
   },
   {
@@ -424,9 +423,11 @@ export default tseslint.config(
       'vitest/no-conditional-expect': 'off',
       'vitest/no-export': 'off',
       'vitest/no-focused-tests': ['warn', { fixable: false }],
+      'vitest/prefer-describe-function-title': 'warn',
       'vitest/require-top-level-describe': 'off',
       'vitest/valid-describe-callback': 'off',
       'vitest/valid-expect-in-promise': 'error',
+      'vitest/valid-title': ['error', { ignoreTypeOfDescribeName: true }],
 
       'import/extensions': ['error', 'never', {
         config: 'ignore'

lib/__test_mocks__/bundles/test0/package.json

@@ -1,3 +1,3 @@
 {
-  "name": "test0"
+  "name": "@sourceacademy/bundle-test0"
 }

lib/__test_mocks__/bundles/test1/package.json

@@ -1,3 +1,3 @@
 {
-  "name": "test1"
+  "name": "@sourceacademy/bundle-test1"
 }

lib/buildtools/src/build/docs/__tests__/index.test.ts

@@ -18,7 +18,7 @@ const mockBundle: ResolvedBundle = {
   manifest: {}
 };
 
-describe('Test buildSingleBundleDocs', () => {
+describe(buildSingleBundleDocs, () => {
   const mockedJsonInit = vi.spyOn(init, 'initTypedocForJson');
   test('Project conversion failure', async () => {
     const mockGenerateJson = vi.fn(() => Promise.resolve());
@@ -63,7 +63,7 @@ describe('Test buildSingleBundleDocs', () => {
   });
 });
 
-describe('Test buildHtml', () => {
+describe(buildHtml, () => {
   const mockedHtmlInit = vi.spyOn(init, 'initTypedocForHtml');
   const mockedFsStat = vi.spyOn(fs, 'stat');
 

lib/buildtools/src/build/docs/__tests__/json.test.ts

@@ -12,7 +12,7 @@ vi.setConfig({
   testTimeout: 10000
 });
 
-describe('Test buildJson', () => {
+describe(buildJson, () => {
   interface Fixtures {
     testBundle: ResolvedBundle;
     project: td.ProjectReflection;

lib/buildtools/src/commands/__tests__/commandUtils.test.ts

@@ -2,7 +2,7 @@ import type { Severity } from '@sourceacademy/modules-repotools/types';
 import { describe, expect, test } from 'vitest';
 import { processResult } from '../commandUtils.js';
 
-describe('Testing processResults', () => {
+describe(processResult, () => {
   const testCases: [any, Severity][] = [
     [{ severity: 'success' }, 'success'],
     [{ severity: 'error' }, 'error'],

lib/buildtools/src/commands/__tests__/list.test.ts

@@ -6,8 +6,8 @@ import { testMocksDir } from '../../__tests__/fixtures.js';
 import { getListBundlesCommand, getListTabsCommand } from '../list.js';
 import { getCommandRunner } from './testingUtils.js';
 
-vi.spyOn(console, 'log');
-vi.spyOn(console, 'error');
+const mockedConsoleLog = vi.spyOn(console, 'log');
+const mockedConsoleError = vi.spyOn(console, 'error');
 
 describe('Test list command with bundles', () => {
   const mockedResolveSingleBundle = vi.spyOn(manifest, 'resolveSingleBundle');
@@ -18,7 +18,7 @@ describe('Test list command with bundles', () => {
   test('Running command with no arguments', async ({ expect }) => {
     await expect(runCommand()).commandSuccess();
     expect(console.log).toHaveBeenCalledTimes(1);
-    const [[data]] = vi.mocked(console.log).mock.calls;
+    const [[data]] = mockedConsoleLog.mock.calls;
     expect(data).toMatch(/^Detected 2 bundles in .+:\n1. test0\n2. test1$/);
   });
 
@@ -30,7 +30,7 @@ describe('Test list command with bundles', () => {
     await expect(runCommand()).commandExit();
 
     expect(console.error).toHaveBeenCalledTimes(1);
-    const [[data]] = vi.mocked(console.error).mock.calls;
+    const [[data]] = mockedConsoleError.mock.calls;
     expect(data).toMatch(/^No bundles in .+$/);
   });
 
@@ -43,7 +43,7 @@ describe('Test list command with bundles', () => {
     await expect(runCommand(`${testMocksDir}/bundles/test0`)).commandSuccess();
 
     expect(console.log).toHaveBeenCalledTimes(1);
-    const [[data]] = vi.mocked(console.log).mock.calls;
+    const [[data]] = mockedConsoleLog.mock.calls;
     const sanitized = (data as string).split('\n').join('');
 
     const match = /^.+:(\{.+\})$/gm.exec(sanitized);
@@ -94,7 +94,7 @@ describe('Test list command with tabs', () => {
     await expect(runCommand()).commandSuccess();
 
     expect(console.log).toHaveBeenCalledTimes(1);
-    const [[data]] = vi.mocked(console.log).mock.calls;
+    const [[data]] = mockedConsoleLog.mock.calls;
     expect(data).toMatch(/^Detected 2 tabs in .+:\n1. tab0\n2. tab1$/);
   });
 
@@ -106,7 +106,7 @@ describe('Test list command with tabs', () => {
     await expect(runCommand()).commandExit();
 
     expect(console.error).toHaveBeenCalledTimes(1);
-    const [[data]] = vi.mocked(console.error).mock.calls;
+    const [[data]] = mockedConsoleError.mock.calls;
     expect(data).toMatch(/^No tabs in .+$/);
   });
 
@@ -119,7 +119,7 @@ describe('Test list command with tabs', () => {
     await expect(runCommand(`${testMocksDir}/tabs/tab0`)).commandSuccess();
 
     expect(console.log).toHaveBeenCalledTimes(1);
-    const [[data]] = vi.mocked(console.log).mock.calls;
+    const [[data]] = mockedConsoleLog.mock.calls;
     expect(data).toMatch(/^Tab 'tab0' found in .+$/);
   });
 });

lib/repotools/src/__mocks__/getGitRoot.ts

@@ -1,8 +1,8 @@
-import { resolve } from 'path';
+import { join, resolve } from 'path';
 
-const testMocksDir = resolve(import.meta.dirname, '../../__test_mocks__');
+const testMocksDir = resolve(import.meta.dirname, '../../../__test_mocks__');
 
-export const getBundlesDir = () => Promise.resolve(`${testMocksDir}/bundles`);
-export const getTabsDir = () => Promise.resolve(`${testMocksDir}/tabs`);
-export const getOutDir = () => Promise.resolve('/build');
+export const bundlesDir = join(testMocksDir, 'bundles');
+export const tabsDir = join(testMocksDir, 'tabs');
+export const outDir = '/build';
 export const getGitRoot = () => Promise.resolve(testMocksDir);