Skip to content

Commit 434a37c

Browse files
committed
Needed to move the check to another function
1 parent 2b8b79e commit 434a37c

File tree

1 file changed

+29
-29
lines changed

1 file changed

+29
-29
lines changed

.github/actions/src/info/index.ts

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -166,34 +166,28 @@ function rawRecordToFullRecord(
166166
): PackageRecord {
167167
const needsPlaywright = !!devDependencies && 'playwright' in devDependencies;
168168

169-
if (
170-
packageName !== '@sourceacademy/bundles' &&
171-
packageName !== '@sourceacademy/tabs' &&
172-
packageName !== '@sourceacademy/modules'
173-
) {
174-
const match = packageNameRE.exec(packageName);
175-
if (!match) throw new Error(`Unknown package ${packageName}`);
176-
177-
const [, packageType, baseName] = match;
178-
179-
switch (packageType) {
180-
case 'bundle':
181-
return {
182-
changes: hasChanges,
183-
directory: directory,
184-
name: packageName,
185-
needsPlaywright,
186-
bundleName: baseName,
187-
};
188-
case 'tab':
189-
return {
190-
changes: hasChanges,
191-
directory: directory,
192-
name: packageName,
193-
needsPlaywright,
194-
tabName: baseName,
195-
};
196-
}
169+
const match = packageNameRE.exec(packageName);
170+
if (!match) throw new Error(`Unknown package ${packageName}`);
171+
172+
const [, packageType, baseName] = match;
173+
174+
switch (packageType) {
175+
case 'bundle':
176+
return {
177+
changes: hasChanges,
178+
directory: directory,
179+
name: packageName,
180+
needsPlaywright,
181+
bundleName: baseName,
182+
};
183+
case 'tab':
184+
return {
185+
changes: hasChanges,
186+
directory: directory,
187+
name: packageName,
188+
needsPlaywright,
189+
tabName: baseName,
190+
};
197191
}
198192

199193
return {
@@ -214,7 +208,13 @@ async function processPackages(gitRoot: string) {
214208
const tabs: PackageRecord[] = [];
215209
const libs: PackageRecord[] = [];
216210

217-
for (const fullRecord of Object.values(packages)) {
211+
for (const [packageName, fullRecord] of Object.entries(packages)) {
212+
if (
213+
packageName === '@sourceacademy/modules' ||
214+
packageName === '@sourceacademy/bundles' ||
215+
packageName === '@sourceacademy/tabs'
216+
) continue;
217+
218218
if ('bundleName' in fullRecord) {
219219
bundles.push(fullRecord);
220220
} else if ('tabName' in fullRecord) {

0 commit comments

Comments
 (0)