Use instanceof for type guards

leeyi45 · leeyi45 · commit 4873bfb9ab9a · 2025-09-12T14:13:33.000-04:00
diff --git a/lib/modules-lib/src/types/index.ts b/lib/modules-lib/src/types/index.ts
@@ -19,7 +19,7 @@ export abstract class glAnimation {
 
   public abstract getFrame(timestamp: number): AnimFrame;
 
-  public static isAnimation = (obj: any): obj is glAnimation => obj.fps !== undefined;
+  public static isAnimation = (obj: any): obj is glAnimation => obj instanceof glAnimation;
 }
 export interface AnimFrame {
   draw: (canvas: HTMLCanvasElement) => void;
diff --git a/src/bundles/rune/src/functions.ts b/src/bundles/rune/src/functions.ts
@@ -650,7 +650,7 @@ export class HollusionRune extends DrawnRune {
 }
 
 /** @hidden */
-export const isHollusionRune = (rune: DrawnRune): rune is HollusionRune => rune.isHollusion;
+export const isHollusionRune = (rune: DrawnRune): rune is HollusionRune => rune instanceof HollusionRune;
 
 /**
  * Makes a new Rune from two given Runes by

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ export abstract class glAnimation {`
`19`	`19`
`20`	`20`	`public abstract getFrame(timestamp: number): AnimFrame;`
`21`	`21`
`22`		`- public static isAnimation = (obj: any): obj is glAnimation => obj.fps !== undefined;`
	`22`	`+ public static isAnimation = (obj: any): obj is glAnimation => obj instanceof glAnimation;`
`23`	`23`	`}`
`24`	`24`	`export interface AnimFrame {`
`25`	`25`	`draw: (canvas: HTMLCanvasElement) => void;`
Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,7 @@ export class HollusionRune extends DrawnRune {`
`650`	`650`	`}`
`651`	`651`
`652`	`652`	`/** @hidden */`
`653`		`-export const isHollusionRune = (rune: DrawnRune): rune is HollusionRune => rune.isHollusion;`
	`653`	`+export const isHollusionRune = (rune: DrawnRune): rune is HollusionRune => rune instanceof HollusionRune;`
`654`	`654`
`655`	`655`	`/**`
`656`	`656`	`* Makes a new Rune from two given Runes by`