Fix missing dependencies again

Author: leeyi45

.github/actions/src/info/index.ts

@@ -3,13 +3,23 @@ import pathlib from 'path';
 import * as core from '@actions/core';
 import { getExecOutput } from '@actions/exec';
 
-interface PackageRecord {
+interface BasePackageRecord {
   directory: string
   name: string
   changes: boolean
   needsPlaywright: boolean
 }
 
+interface BundlePackageRecord extends BasePackageRecord {
+  bundleName: string;
+}
+
+interface TabPackageRecord extends BasePackageRecord {
+  tabName: string;
+}
+
+type PackageRecord = BundlePackageRecord | TabPackageRecord | BasePackageRecord;
+
 /**
  * Returns `true` if there are changes present in the given directory relative to
  * the master branch\
@@ -31,7 +41,9 @@ async function checkForChanges(directory: string) {
  * Recursively locates the packages present in a directory, up to an optional max depth
  */
 async function findPackages(directory: string, maxDepth?: number) {
-  const output: PackageRecord[] = [];
+  const output: BasePackageRecord[] = [];
+  const RE = /^@sourceacademy\/(.+?)-(.+)$/u;
+
   async function* recurser(currentDir: string, currentDepth: number): AsyncGenerator<PackageRecord> {
     if (maxDepth !== undefined && currentDepth >= maxDepth) return;
 
@@ -42,13 +54,46 @@ async function findPackages(directory: string, maxDepth?: number) {
         if (item.name === 'package.json') {
           try {
             const { default: { name, devDependencies } } = await import(fullPath, { with: { type: 'json' }});
+            const match = RE.exec(name);
             const changes = await checkForChanges(currentDir);
-            yield {
-              directory: currentDir,
-              changes,
-              name,
-              needsPlaywright: 'playwright' in devDependencies
-            };
+
+            if (!match) {
+              throw new Error(`Failed to match package name: ${name}`);
+            }
+
+            const [,packageType, packageBaseName] = match;
+
+            switch (packageType) {
+              case 'bundle': {
+                yield {
+                  directory: currentDir,
+                  changes,
+                  name,
+                  needsPlaywright: false,
+                  bundleName: packageBaseName,
+                };
+                break;
+              }
+              case 'tab': {
+                yield {
+                  directory: currentDir,
+                  changes,
+                  name,
+                  needsPlaywright: 'playwright' in devDependencies,
+                  tabName: packageBaseName,
+                };
+                break;
+              }
+              default: {
+                yield {
+                  directory: currentDir,
+                  changes,
+                  name,
+                  needsPlaywright: 'playwright' in devDependencies
+                };
+                break;
+              }
+            }
             return;
           } catch {}
         }
@@ -77,7 +122,7 @@ async function main() {
       libs: pathlib.join(gitRoot, 'lib'),
       bundles: pathlib.join(gitRoot, 'src', 'bundles'),
       tabs: pathlib.join(gitRoot, 'src', 'tabs')
-    }).map(async ([packageType, dirPath]): Promise<[string, PackageRecord[]]> => {
+    }).map(async ([packageType, dirPath]): Promise<[string, BasePackageRecord[]]> => {
       const packages = await findPackages(dirPath);
       core.info(`Found ${packages.length} ${packageType} packages`);
       return [packageType, packages];

.github/workflows/workflow-again.yml

@@ -37,6 +37,49 @@ jobs:
       tabs: ${{ steps.info.outputs.tabs }}
       libs: ${{ steps.info.outputs.libs }}
 
+  libraries:
+    name: Libaries
+    runs-on: ubuntu-latest
+    needs: find-packages
+    strategy:
+      fail-fast: false
+      matrix:
+        lib: ${{ fromJson(needs.find-packages.outputs.libs) }}
+    steps:
+      - name: Check out source code
+        uses: actions/checkout@v4
+
+      - name: Enable Corepack
+        run: corepack enable
+
+      - name: Use Node.js 💻
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: .node-version
+          cache: yarn
+
+      - name: Install Dependencies
+        run: yarn workspaces focus ${{ matrix.lib.name }}
+
+      - name: Install Playwright (if needed)
+        if: matrix.lib.changes == 'true' && matrix.lib.needsPlaywright
+        run: |
+          cd ${{ matrix.lib.directory }}
+          yarn playwright install --with-deps
+
+      - name: Run Tests
+        if: matrix.lib.changes == 'true'
+        run: |
+          cd ${{ matrix.lib.directory }}
+          yarn test
+
+      - name: Run Auxillary Tasks
+        if: matrix.lib.changes == 'true'
+        run: |
+          cd ${{ matrix.lib.directory }}
+          yarn tsc
+          yarn lint
+
   tabs:
     name: Tabs
     runs-on: ubuntu-latest
@@ -65,6 +108,12 @@ jobs:
       - name: Build Tab
         run: yarn workspaces foreach -A --include ${{ matrix.tabInfo.name }} run build
 
+      - name: Cache Tab
+        uses: actions/cache/save@v4
+        with:
+          path: ./build/tabs/${{ matrix.tabInfo.tabName }}.js
+          key: ${{ matrix.tabInfo.name }}
+
       - name: Install Playwright (if needed)
         if: matrix.tabInfo.changes == 'true' && matrix.tabInfo.needsPlaywright
         run: |
@@ -115,6 +164,18 @@ jobs:
           yarn build
           yarn tsc
 
+      - name: Cache Buildtools Compiled Bundle
+        uses: actions/cache/save@v4
+        with:
+          path: ./build/bundles/${{ matrix.bundleInfo.bundleName }}.js
+          key: ${{ matrix.bundleInfo.name }}-buildtools
+
+      - name: Cache tsc Compiled Bundle
+        uses: actions/cache/save@v4
+        with:
+          path: ${{ matrix.bundleInfo.directory }}/dist
+          key: ${{ matrix.bundleInfo.name }}-tsc
+
       - name: Run Tests
         if: matrix.bundleInfo.changes == 'true'
         run: |
@@ -127,4 +188,26 @@ jobs:
           cd ${{ matrix.bundleInfo.directory }}
           yarn tsc
           yarn lint
-  
+  
+  devserver:
+    name: Dev Server Tests
+    runs-on: ubuntu-latest
+    needs:
+      - bundles
+      - tabs
+
+    steps:
+      - name: Check out source code
+        uses: actions/checkout@v4
+
+      - name: Enable Corepack
+        run: corepack enable
+
+      - name: Use Node.js 💻
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: .node-version
+          cache: yarn
+
+      - name: Install Dependencies
+        run: yarn workspaces focus @sourceacademy/modules-devserver

src/bundles/midi/package.json

@@ -6,6 +6,9 @@
     "@sourceacademy/modules-buildtools": "workspace:^",
     "typescript": "^5.8.2"
   },
+  "dependencies": {
+    "js-slang": "^1.0.81"
+  },
   "type": "module",
   "scripts": {
     "build": "buildtools build bundle .",

yarn.lock

@@ -3163,6 +3163,7 @@ __metadata:
   resolution: "@sourceacademy/bundle-midi@workspace:src/bundles/midi"
   dependencies:
     "@sourceacademy/modules-buildtools": "workspace:^"
+    js-slang: "npm:^1.0.81"
     typescript: "npm:^5.8.2"
   languageName: unknown
   linkType: soft