Fix missing tests for lint plugin tab-type

Author: leeyi45

lib/buildtools/build.js

@@ -21,15 +21,20 @@ const command = getBuildCommand({
   target: 'node20',
   tsconfig: './tsconfig.json',
   plugins: [{
+    // If the given path resolves to something in the root of the repository
+    // then replace the path and externalize the import instead
     name: 'Local Externalizer',
     setup({ onResolve }) {
       onResolve({
         filter: /^\.{1,2}(\/.+)?/
       }, args => {
         const absolutePath = pathlib.resolve(args.resolveDir, args.path);
         const { dir, ext, base } = pathlib.parse(absolutePath);
+        // evan claims that esbuild doesn't rewrite import attributes
+        // but i can't get json imports to work properly
         if (ext === '.json' || dir !== repoRoot) return undefined;
 
+        // The new import path should be relative to the bin/index.js file
         const newDirectory = pathlib.relative('./bin', repoRoot);
         return {
           external: true,

lib/buildtools/package.json

@@ -24,7 +24,7 @@
     "astring": "^1.8.6",
     "chalk": "^5.0.1",
     "commander": "^13.0.0",
-    "esbuild": "^0.25.5",
+    "esbuild": "^0.25.8",
     "eslint": "^9.31.0",
     "jsonschema": "^1.5.0",
     "lodash": "^4.17.21",

lib/lib-compiler/package.json

@@ -11,7 +11,7 @@
   "dependencies": {
     "chalk": "^5.0.1",
     "commander": "^13.0.0",
-    "esbuild": "^0.25.5"
+    "esbuild": "^0.25.8"
   },
   "exports": {
     ".": {

lib/lintplugin/package.json

@@ -26,7 +26,6 @@
   "devDependencies": {
     "@sourceacademy/lib-compiler": "workspace:^",
     "@sourceacademy/modules-buildtools": "workspace:^",
-    "@typescript-eslint/rule-tester": "^8.33.1",
     "typescript": "^5.8.2"
   },
   "scripts": {

lib/lintplugin/src/rules/__tests__/tabType.test.ts

@@ -0,0 +1,43 @@
+import { RuleTester } from 'eslint';
+import tabType from '../tabType';
+
+describe('Test collateTypeImports', () => {
+  const tester = new RuleTester();
+  tester.run(
+    'tab-type',
+    tabType,
+    {
+      valid: [{
+        code: `
+          import { defineTab } from '@sourceacademy/modules-lib/tabs/utils';
+          export default defineTab({})
+        `
+      }, {
+        code: `
+          import { defineTab as definer } from '@sourceacademy/modules-lib/tabs/utils';
+          export default definer({})
+        `
+      }, {code: `
+        import { stuff } from 'somewhere';
+        import { defineTab as definer } from '@sourceacademy/modules-lib/tabs/utils';
+        export default definer({ stuff })
+      `}],
+      invalid: [{
+        code: '',
+        errors: 1
+      }, {
+        code: `
+          import { stuff } from 'somwhere';
+          export default 0;
+        `,
+        errors: 1
+      }, {
+        code: `
+          import { defineTab } from '@sourceacademy/modules-lib/tabs/utils';
+          export default 0;
+        `,
+        errors: 1
+      }]
+    }
+  );
+});

lib/lintplugin/src/rules/__tests__/typeimports.test.ts

@@ -63,7 +63,7 @@
     "@vitest/coverage-v8": "^3.2.3",
     "@vitest/eslint-plugin": "^1.3.4",
     "@yarnpkg/types": "^4.0.1",
-    "esbuild": "^0.25.5",
+    "esbuild": "^0.25.8",
     "eslint": "^9.31.0",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jsdoc": "^51.3.1",