Skip to content

Commit 9edff7c

Browse files
committed
Test that removing the preinstall script from the root package makes installations work better
1 parent 910d839 commit 9edff7c

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/pull-request.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
playwright: ${{ steps.filter.outputs.devserver || steps.filter.outputs.libraries || steps.filter.outputs.tabs }}
4343

4444
test:
45-
name: Verify all tests pass and build success
45+
name: Verify that all tests, linting, type-checking and building succeeds.
4646
runs-on: ubuntu-latest
4747

4848
# execute after the paths-filter job is done
@@ -62,8 +62,8 @@ jobs:
6262
node-version: 22
6363
cache: yarn
6464

65-
- name: Setup Repotools
66-
run: yarn workspaces focus @sourceacademy/modules-repotools && yarn workspaces foreach -A --include "@sourceacademy/modules-repotools" run build
65+
# - name: Setup Repotools
66+
# run: yarn workspaces focus @sourceacademy/modules-repotools && yarn workspaces foreach -A --include "@sourceacademy/modules-repotools" run build
6767

6868
- name: Install dependencies
6969
run: yarn install --immutable

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
"lint:all": "buildtools lintglobal && yarn lint:modules",
3636
"lint:inspect": "yarn dlx eslint --inspect-config",
3737
"lint:modules": "yarn workspaces foreach -j 5 -pW --from \"./src/{bundles,tabs}\" run lint",
38-
"preinstall": "yarn build:libs",
3938
"prepare": "husky",
4039
"run:bundles": "yarn workspaces foreach -ptW --from \"./src/bundles/*\" run",
4140
"serve": "http-server --cors=* -c-1 -p 8022 ./build",

vitest.config.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
import pathlib from 'path';
44
import { coverageConfigDefaults, defineConfig } from 'vitest/config';
55

6+
const coverageReporters = ['html', 'text'];
7+
if (process.env.GITHUB_ACTIONS) {
8+
coverageReporters.push('github-actions');
9+
}
10+
611
export default defineConfig({
712
resolve: {
813
alias: [{
@@ -20,7 +25,7 @@ export default defineConfig({
2025
clearMocks: true,
2126
coverage: {
2227
provider: 'v8',
23-
reporter: ['html', 'text'],
28+
reporter: coverageReporters,
2429
exclude: [
2530
...coverageConfigDefaults.exclude,
2631
'./build/**',

0 commit comments

Comments
 (0)