Skip to content

Commit a23afae

Browse files
committed
Figure out if docserver and devserver are being accurately represented
1 parent 21018aa commit a23afae

File tree

2 files changed

+31
-5
lines changed

2 files changed

+31
-5
lines changed

.github/actions/src/info/index.ts

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,24 @@ export async function getAllPackages(gitRoot: string) {
199199
};
200200
}
201201

202+
/**
203+
* Use the Github actions core.setOutput function, but this is just here
204+
* for type safety
205+
*/
206+
function setOutputs(
207+
bundles: PackageRecord[],
208+
tabs: PackageRecord[],
209+
libs: PackageRecord[],
210+
devserver: PackageRecord,
211+
docserver: PackageRecord
212+
) {
213+
core.setOutput('bundles', bundles);
214+
core.setOutput('tabs', tabs);
215+
core.setOutput('libs', libs);
216+
core.setOutput('devserver', devserver);
217+
core.setOutput('docserver', docserver);
218+
}
219+
202220
async function main() {
203221
const gitRoot = await getGitRoot();
204222
const { packages, bundles, tabs, libs } = await getAllPackages(gitRoot);
@@ -218,11 +236,13 @@ async function main() {
218236
core.summary.addList(summaryItems);
219237
await core.summary.write();
220238

221-
core.setOutput('bundles', Object.values(bundles));
222-
core.setOutput('tabs', Object.values(tabs));
223-
core.setOutput('libs', Object.values(libs));
224-
core.setOutput('devserver', packages['@sourceacademy/modules-devserver']);
225-
core.setOutput('docserver', packages['@sourceacademy/modules-docserver']);
239+
setOutputs(
240+
Object.values(bundles),
241+
Object.values(tabs),
242+
Object.values(libs),
243+
packages['@sourceacademy/modules-devserver'],
244+
packages['@sourceacademy/modules-docserver']
245+
);
226246

227247
const workflows = await checkForChanges(pathlib.join(gitRoot, '.github/workflows'));
228248
core.setOutput('workflows', workflows);

.github/workflows/pull-request.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@ jobs:
3939
id: info
4040
uses: ./.github/actions/src/info
4141

42+
- name: Echo Information about docserver
43+
run: echo ${{ steps.info.outputs.docserver }}
44+
45+
- name: Echo Information about devserver
46+
run: echo ${{ steps.info.outputs.devserver }}
47+
4248
outputs:
4349
bundles: ${{ steps.info.outputs.bundles }}
4450
libs: ${{ steps.info.outputs.libs }}

0 commit comments

Comments
 (0)