Update some tests

Author: leeyi45

src/bundles/midi/src/__tests__/index.test.ts

@@ -1,31 +1,21 @@
-import { head, tail, type List } from 'js-slang/dist/stdlib/list';
+import { list_to_vector } from 'js-slang/dist/stdlib/list';
 import { describe, expect, test } from 'vitest';
 import { letter_name_to_midi_note, midi_note_to_letter_name } from '..';
 import { major_scale, minor_scale } from '../scales';
 import { Accidental, type Note, type NoteWithOctave } from '../types';
 import { noteToValues } from '../utils';
 
-function list_to_array(list: List) {
-  const output: number[] = [];
-  while (list !== null) {
-    output.push(head(list));
-    list = tail(list);
-  }
-
-  return output;
-}
-
 describe('scales', () => {
   test('major_scale', () => {
     const c0 = letter_name_to_midi_note('C0');
     const scale = major_scale(c0);
-    expect(list_to_array(scale)).toMatchObject([12, 14, 16, 17, 19, 21, 23, 24]);
+    expect(list_to_vector(scale)).toMatchObject([12, 14, 16, 17, 19, 21, 23, 24]);
   });
 
   test('minor_scale', () => {
     const a0 = letter_name_to_midi_note('A0');
     const scale = minor_scale(a0);
-    expect(list_to_array(scale)).toMatchObject([21, 23, 24, 26, 28, 29, 31, 33]);
+    expect(list_to_vector(scale)).toMatchObject([21, 23, 24, 26, 28, 29, 31, 33]);
   });
 });
 

src/bundles/pix_n_flix/vitest.config.ts

@@ -1,4 +1,3 @@
-import { playwright } from '@vitest/browser-playwright';
 import { defineProject } from 'vitest/config';
 
 export default defineProject({
@@ -14,10 +13,6 @@ export default defineProject({
     name: 'pix_n_flix Bundle',
     browser: {
       enabled: true,
-      provider: playwright(),
-      instances: [{
-        browser: 'chromium',
-      }]
     }
   }
 });

src/bundles/sound/src/__tests__/recording.test.ts

@@ -63,7 +63,7 @@ describe('Recording functions', () => {
 
   describe(funcs.record, () => {
     test('throws error if called without init_record', () => {
-      expect(() => funcs.record(0)).toThrowError('Call init_record(); to obtain permission to use microphone');
+      expect(() => funcs.record(0)).toThrowError('record: Call init_record(); to obtain permission to use microphone');
     });
 
     test('throws error if called concurrently with another sound', () => {
@@ -101,7 +101,7 @@ describe('Recording functions', () => {
 
   describe(funcs.record_for, () => {
     test('throws error if called without init_record', () => {
-      expect(() => funcs.record_for(0, 0)).toThrowError('Call init_record(); to obtain permission to use microphone');
+      expect(() => funcs.record_for(0, 0)).toThrowError('record_for: Call init_record(); to obtain permission to use microphone');
     });
 
     test('throws error if called concurrently with another sound', () => {

src/bundles/sound/src/functions.ts

@@ -92,11 +92,11 @@ function linear_decay(decay_period: number): (t: number) => number {
  * Determine if the user has already provided permission to use the
  * microphone and return the provided MediaStream if they have.
  */
-function check_permission() {
+function getAudioStream(func_name: string) {
   if (globalVars.stream === null) {
-    throw new Error('Call init_record(); to obtain permission to use microphone');
+    throw new Error(`${func_name}: Call init_record(); to obtain permission to use microphone`);
   } else if (globalVars.stream === false) {
-    throw new Error(`Permission has been denied.\n
+    throw new Error(`${func_name}: Permission has been denied.\n
         Re-start browser and call init_record();\n
         to obtain permission to use microphone.`);
   }
@@ -201,7 +201,7 @@ export function record(buffer: number): () => SoundPromise {
     throw new Error(`${record.name}: Cannot record while another sound is playing!`);
   }
 
-  const stream = check_permission();
+  const stream = getAudioStream(record.name);
   const mediaRecorder = new MediaRecorder(stream);
 
   setTimeout(() => {
@@ -254,7 +254,7 @@ export function record_for(duration: number, buffer: number): SoundPromise {
     throw new Error(`${record_for.name}: Cannot record while another sound is playing!`);
   }
 
-  const stream = check_permission();
+  const stream = getAudioStream(record_for.name);
   const mediaRecorder = new MediaRecorder(stream);
 
   // order of events for record_for:
@@ -380,8 +380,7 @@ export function play_wave(wave: Wave, duration: number): Sound {
 }
 
 /**
- * Plays the given Sound using the computer’s sound device.
- * The sound is added to a list of sounds to be played one-at-a-time
+ * Adds the given Sound to a list of sounds to be played one-at-a-time
  * in a Source Academy tab.
  *
  * @param sound the Sound to play
@@ -392,7 +391,6 @@ export function play_in_tab(sound: Sound): Sound {
   // Type-check sound
   if (!is_sound(sound)) {
     throw new Error(`${play_in_tab.name} is expecting sound, but encountered ${sound}`);
-    // If a sound is already playing, terminate execution.
   }
 
   const duration = get_duration(sound);