Increase timeout for build:all test

Author: leeyi45

lib/buildtools/src/build/manifest.ts

@@ -12,30 +12,35 @@ import manifestSchema from './modules/manifest.schema.json' with { type: 'json'
  * Checks that the given bundle manifest was correctly specified
  */
 export async function getBundleManifest(manifestFile: string, tabCheck?: boolean): Promise<BundleManifest | undefined> {
-  let rawManifest: string;
+  let manifestStr: string;
 
   try {
-    rawManifest = await fs.readFile(manifestFile, 'utf-8');
+    manifestStr = await fs.readFile(manifestFile, 'utf-8');
   } catch (error) {
     if (isNodeError(error) && error.code === 'ENOENT') {
       return undefined;
     }
     throw error;
   }
 
-  const data = JSON.parse(rawManifest) as BundleManifest;
-  validate(data, manifestSchema, { throwError: true });
+  const rawManifest = JSON.parse(manifestStr) as BundleManifest;
+  validate(rawManifest, manifestSchema, { throwError: true });
+
+  const manifest = {
+    ...rawManifest,
+    tabs: !rawManifest.tabs ? rawManifest.tabs : rawManifest.tabs.map(each => each.trim()),
+  };
 
   // Make sure that all the tabs specified exist
-  if (tabCheck && data.tabs) {
+  if (tabCheck && manifest.tabs) {
     const tabsDir = await getTabsDir();
-    await Promise.all(data.tabs.map(async tabName => {
+    await Promise.all(manifest.tabs.map(async tabName => {
       const resolvedTab = await resolveSingleTab(`${tabsDir}/${tabName}`);
       if (resolvedTab === undefined) throw new Error(`Failed to find tab with name '${tabName}'!`);
     }));
   }
 
-  return data;
+  return manifest;
 }
 
 /**

lib/buildtools/src/build/modules/manifest.schema.json

@@ -11,7 +11,8 @@
     },
     "version": {
       "type": "string",
-      "description": "Version of your bundle"
+      "description": "Version of your bundle",
+      "pattern": "^[0-9]+(\\.[0-9]){0,2}$"
     },
     "requires": {
       "enum": [1, 2, 3, 4],

lib/buildtools/src/commands/__tests__/buildAll.test.ts

@@ -54,7 +54,7 @@ const mockedTsc = vi.spyOn(tsc, 'runTsc').mockImplementation(input => Promise.re
 describe('Test build:all command', () => {
   const runCommand = getCommandRunner(getBuildAllCommand);
 
-  test('Regular command execution', async () => {
+  test('Regular command execution', { timeout: 10000 }, async () => {
     await expect(runCommand()).commandSuccess();
 
     // Two bundles, so two calls to buildBundle