Skip to content

Commit c52eec3

Browse files
committed
Fix devserver workflow not working and modules-lib install taking forever
1 parent 9c42e37 commit c52eec3

File tree

3 files changed

+38
-17
lines changed

3 files changed

+38
-17
lines changed

.github/actions/src/info/index.ts

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import fs from 'fs/promises';
22
import pathlib from 'path';
33
import utils from 'util';
44
import * as core from '@actions/core';
5+
import type { SummaryTableRow } from '@actions/core/lib/summary.js';
56
import { checkForChanges, getGitRoot, type PackageRecord, type RawPackageRecord } from '../commons.js';
67
import { topoSortPackages } from './sorter.js';
78

@@ -220,19 +221,36 @@ async function main() {
220221
const gitRoot = await getGitRoot();
221222
const { packages, bundles, tabs, libs } = await getAllPackages(gitRoot);
222223

223-
const summaryItems = Object.values(packages).map(packageInfo => {
224+
const summaryItems = Object.values(packages).map((packageInfo): SummaryTableRow => {
224225
const relpath = pathlib.relative(gitRoot, packageInfo.directory);
225-
return `<div>
226-
<h2>${packageInfo.name}</h2>
227-
<ul>
228-
<li>Directory: <code>${relpath}</code></li>
229-
<li>Changes: <code>${packageInfo.changes}</code></li>
230-
<li>Needs Playwright: <code>${packageInfo.needsPlaywright}</code></li>
231-
</ul>
232-
</div>`;
226+
return [
227+
packageInfo.name,
228+
relpath,
229+
packageInfo.changes ? 'true' : 'false',
230+
packageInfo.needsPlaywright ? 'true' : 'false'
231+
];
233232
});
234233

235-
core.summary.addList(summaryItems);
234+
summaryItems.unshift([
235+
{
236+
data: 'Package Name',
237+
header: true,
238+
},
239+
{
240+
data: 'Package Path',
241+
header: true
242+
},
243+
{
244+
data: 'Has Changes',
245+
header: true
246+
},
247+
{
248+
data: 'Needs Playwright',
249+
header: true
250+
}
251+
]);
252+
253+
core.summary.addTable(summaryItems);
236254
await core.summary.write();
237255

238256
setOutputs(

.github/workflows/pull-request.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,9 @@ jobs:
199199
playwright: true
200200

201201
- name: Build Manifest
202-
run: yarn buildtools manifest
202+
run: |
203+
cd ./devserver
204+
yarn buildtools manifest
203205
204206
- name: Run tests
205207
run: |
@@ -255,8 +257,9 @@ jobs:
255257
- name: Build Manifest
256258
run: yarn buildtools manifest
257259

258-
- name: Upload Manifest
259-
uses: actions/upload-artifact@v4
260-
with:
261-
name: manifest
262-
path: ./build/modules.json
260+
# Not sure if we need to upload this as an artifact
261+
# - name: Upload Manifest
262+
# uses: actions/upload-artifact@v4
263+
# with:
264+
# name: manifest
265+
# path: ./build/modules.json

lib/modules-lib/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"build": "tsc --project ./tsconfig.prod.json",
4545
"docs": "typedoc",
4646
"lint": "eslint src",
47-
"postinstall": "yarn build && playwright install --with-deps",
47+
"postinstall": "yarn build",
4848
"tsc": "tsc --project ./tsconfig.json",
4949
"test": "buildtools test --project ."
5050
}

0 commit comments

Comments
 (0)