Remove useless workspaces and modify templates to include all scripts

Author: leeyi45

.github/actions/src/info/index.ts

@@ -113,11 +113,7 @@ export function processRawPackages(topoOrder: string[], packages: Record<string,
       packageInfo.package.devDependencies !== undefined &&
       'playwright' in packageInfo.package.devDependencies;
 
-    if (
-      packageName !== '@sourceacademy/modules' &&
-      packageName !== '@sourceacademy/bundles' &&
-      packageName !== '@sourceacademy/tabs'
-    ) {
+    if (packageName !== '@sourceacademy/modules') {
       const match = packageNameRE.exec(packageName);
       if (!match) throw new Error(`Unknown package ${packageName}`);
 
@@ -183,10 +179,6 @@ export async function getAllPackages(gitRoot: string) {
     ...tabs,
     ...libs
   };
-  // Remove the root packages from the bundles and tabs collection
-  // of packages cause they're not supposed be used like that
-  delete bundles['@sourceacademy/bundles'];
-  delete tabs['@sourceacademy/tabs'];
 
   const sort = topoSortPackages(packages);
   const processed = processRawPackages(sort, packages);

lib/buildtools/src/commands/prebuild.ts

@@ -1,5 +1,6 @@
 import pathlib from 'path';
 import { Command } from '@commander-js/extra-typings';
+import { outDir } from '@sourceacademy/modules-repotools/getGitRoot';
 import { resolveEitherBundleOrTab } from '@sourceacademy/modules-repotools/manifest';
 import { divideAndRound } from '@sourceacademy/modules-repotools/utils';
 import chalk from 'chalk';
@@ -64,6 +65,11 @@ export const getLintGlobalCommand = () => new Command('lintglobal')
 
     console.log(logs.join('\n'));
 
+    if (stats) {
+      const statPath = pathlib.join(outDir, 'lintstats.csv');
+      console.log(chalk.greenBright(`Stats written to ${statPath}`));
+    }
+
     switch (result.severity) {
       case 'warn': {
         if (!ci) return;

lib/buildtools/src/templates/bundle.ts

@@ -49,6 +49,8 @@ export async function addNew(bundlesDir: string, rl: Interface) {
     scripts: {
       build: 'buildtools build bundle .',
       lint: 'buildtools lint .',
+      serve: 'yarn buildtools serve',
+      test: 'buildtools test --project .',
       tsc: 'tsc --project ./tsconfig.json',
     },
     exports: {

lib/buildtools/src/templates/tab.ts

@@ -70,7 +70,9 @@ export async function addNew(bundlesDir: string, tabsDir: string, rl: Interface)
     scripts: {
       build: 'buildtools build tab .',
       lint: 'buildtools lint .',
-      tsc: 'tsc --project ./tsconfig.json'
+      test: 'buildtools test --project .',
+      tsc: 'buildtools tsc .',
+      serve: 'yarn buildtools serve'
     }
   };
 

lib/lintplugin/src/rules/__tests__/noBarrelImports.test.ts

@@ -16,6 +16,10 @@ describe('Test noBarrelImports', () => {
           code: "import type { memoize } from 'lodash';",
           options: [['lodash']]
         },
+        {
+          code: "import type * as _ from 'lodash';",
+          options: [['lodash']]
+        },
         {
           code: "import memoize from 'lodash/memoize'\nimport cloneDeep from 'lodash/cloneDeep'",
           options: [['lodash']]

package.json

@@ -102,8 +102,8 @@
     "./devserver",
     "./docs",
     "./lib/*",
-    "./src/bundles",
-    "./src/tabs"
+    "./src/bundles/*",
+    "./src/tabs/*"
   ],
   "resolutions": {
     "vite": "npm:vite@^6.3.5"

src/bundles/package.json

@@ -16,9 +16,9 @@
     "@types/react-dom": "^18.3.1",
     "@vitest/browser": "^3.2.3",
     "@vitest/coverage-v8": "^3.2.3",
+    "playwright": "^1.54.1",
     "vitest": "^3.2.3",
-    "vitest-browser-react": "^1.0.0",
-    "playwright": "^1.54.1"
+    "vitest-browser-react": "^1.0.0"
   },
   "scripts": {
     "build": "buildtools build tab .",

src/tabs/Curve/package.json

@@ -3553,14 +3553,6 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@sourceacademy/bundles@workspace:src/bundles":
-  version: 0.0.0-use.local
-  resolution: "@sourceacademy/bundles@workspace:src/bundles"
-  dependencies:
-    "@sourceacademy/modules-buildtools": "workspace:^"
-  languageName: unknown
-  linkType: soft
-
 "@sourceacademy/lint-plugin@workspace:^, @sourceacademy/lint-plugin@workspace:lib/lintplugin":
   version: 0.0.0-use.local
   resolution: "@sourceacademy/lint-plugin@workspace:lib/lintplugin"
@@ -3869,6 +3861,7 @@ __metadata:
     "@types/react-dom": "npm:^18.3.1"
     "@vitest/browser": "npm:^3.2.3"
     "@vitest/coverage-v8": "npm:^3.2.3"
+    playwright: "npm:^1.54.1"
     react: "npm:^18.3.1"
     react-dom: "npm:^18.3.1"
     vitest: "npm:^3.2.3"
@@ -4097,18 +4090,6 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@sourceacademy/tabs@workspace:src/tabs":
-  version: 0.0.0-use.local
-  resolution: "@sourceacademy/tabs@workspace:src/tabs"
-  dependencies:
-    "@sourceacademy/modules-buildtools": "workspace:^"
-    "@types/react": "npm:^18.3.1"
-    "@types/react-dom": "npm:^18.3.1"
-    react: "npm:^18.3.1"
-    react-dom: "npm:^18.3.1"
-  languageName: unknown
-  linkType: soft
-
 "@stylistic/eslint-plugin@npm:^4.4.1":
   version: 4.4.1
   resolution: "@stylistic/eslint-plugin@npm:4.4.1"