Skip to content

Commit ebb8d9f

Browse files
committed
Change how things are saved as artifacts
1 parent d075987 commit ebb8d9f

File tree

1 file changed

+11
-20
lines changed

1 file changed

+11
-20
lines changed

.github/workflows/pull-request.yml

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,17 @@ jobs:
9494
with:
9595
package-name: ${{ matrix.tabInfo.name }}
9696
playwright: ${{ matrix.tabInfo.needsPlaywright && matrix.tabInfo.changes }}
97-
9897
- name: Build Tab
99-
run: yarn workspaces foreach -A --include ${{ matrix.tabInfo.name }} run build
98+
if: matrix.tabInfo.changes
99+
run: |
100+
cd ${{ matrix.tabInfo.directory }}
101+
yarn build
100102
101-
- name: Cache Tab
102-
uses: actions/cache/save@v4
103+
- name: Upload Tab Artifact
104+
uses: actions/upload-artifact@v4
103105
with:
106+
name: ${{ matrix.tabInfo.tabName }} Tab
104107
path: ./build/tabs/${{ matrix.tabInfo.tabName }}.js
105-
key: ${{ matrix.tabInfo.name }}
106108

107109
- name: Run Tests
108110
# https://github.com/vitest-dev/vitest/issues/5477
@@ -138,35 +140,24 @@ jobs:
138140
package-name: ${{ matrix.bundleInfo.name }}
139141

140142
- name: Build Bundle
143+
if: matrix.bundleInfo.changes
141144
run: |
142145
cd ${{ matrix.bundleInfo.directory }}
143146
yarn build
144147
yarn tsc
145148
146-
- name: Cache Buildtools Compiled Bundle
147-
uses: actions/cache/save@v4
149+
- name: Upload Bundle Artifact
150+
uses: actions/upload-artifact@v4
148151
with:
152+
name: ${{ matrix.bundleInfo.bundleName }} Bundle
149153
path: ./build/bundles/${{ matrix.bundleInfo.bundleName }}.js
150-
key: ${{ matrix.bundleInfo.name }}-buildtools
151-
152-
- name: Cache tsc Compiled Bundle
153-
uses: actions/cache/save@v4
154-
with:
155-
path: ${{ matrix.bundleInfo.directory }}/dist
156-
key: ${{ matrix.bundleInfo.name }}-tsc
157154

158155
- name: Run Tests
159156
if: matrix.bundleInfo.changes
160157
run: |
161158
cd ${{ matrix.bundleInfo.directory }}
162159
yarn test --coverage
163160
164-
- name: Run Auxillary Tasks
165-
if: matrix.bundleInfo.changes
166-
run: |
167-
cd ${{ matrix.bundleInfo.directory }}
168-
yarn tsc
169-
170161
devserver:
171162
name: Dev Server Tests
172163
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)