Fix linting issues

Author: leeyi45

eslint.config.js

@@ -33,6 +33,7 @@ export default tseslint.config(
       'lib/buildtools/src/build/__test_mocks__',
       'lib/lintplugin/dist.js',
       'src/**/samples/**',
+      'src/bundles/scrabble/src/words.json', // Don't lint this because its way too big
       'src/java/**',
       'package-lock.json' // Just in case someone accidentally creates one
     ]
@@ -134,6 +135,8 @@ export default tseslint.config(
       'jsdoc/require-asterisk-prefix': 'warn',
 
       '@stylistic/brace-style': ['warn', '1tbs', { allowSingleLine: true }],
+      '@stylistic/function-call-spacing': ['warn', 'never'],
+      '@stylistic/function-paren-newline': ['warn', 'multiline-arguments'],
       '@stylistic/quotes': ['warn', 'single', { avoidEscape: true }],
       '@stylistic/semi': ['warn', 'always'],
     }
@@ -169,8 +172,6 @@ export default tseslint.config(
       '@typescript-eslint/prefer-ts-expect-error': 'warn',
       '@typescript-eslint/sort-type-constituents': 'warn',
 
-      '@stylistic/function-call-spacing': ['warn', 'never'],
-      '@stylistic/function-paren-newline': ['warn', 'multiline'],
       '@stylistic/type-annotation-spacing': ['warn', { overrides: { colon: { before: false, after: true }}}],
     }
   },

lib/buildtools/src/build/docs/html.ts

@@ -27,4 +27,5 @@ export const {
         message: `${error}`
       };
     }
-  });
+  }
+);

lib/buildtools/src/build/modules/index.ts

@@ -37,5 +37,6 @@ export async function buildTabs(resolvedBundles: Record<string, ResolvedBundle>,
       }
 
       return runBuilderWithPrebuild(buildTab, prebuildOpts, tab, outDir, undefined);
-    }));
+    })
+  );
 }

lib/buildtools/src/commands/__tests__/main.test.ts

@@ -9,6 +9,6 @@ describe('Make sure that all subcommands can execute', () => {
   mainCommand.commands.map(command => test(
     `Test ${command.name()}`,
     () => expect(command.parseAsync(['--help'], { from: 'user' }))
-      .commandExit(0))
-  );
+      .commandExit(0)
+  ));
 });

lib/buildtools/src/commands/__tests__/template.test.ts

@@ -41,7 +41,8 @@ const mockedAskQuestion = vi.mocked(askQuestion);
 
 function expectCall<T extends(...args: any) => any>(
   func: T,
-  ...expected: Parameters<T>[]) {
+  ...expected: Parameters<T>[]
+) {
   const mocked = vi.mocked(func);
 
   expect(func)

lib/modules-lib/src/type_map.ts

@@ -22,7 +22,7 @@ export interface TypeMapUtilities {
  * used to populate it
  */
 export default function createTypeMap(): TypeMapUtilities {
-  const type_map : Record<string, string> = {};
+  const type_map: Record<string, string> = {};
 
   function registerType(name: string, declaration: string) {
     if (name === 'prelude') {

src/bundles/ar/src/AR.ts

@@ -147,9 +147,7 @@ export function addARObject(arObject: ARObject) {
 export function removeARObject(arObject: ARObject) {
   const moduleState = getModuleState();
   if (!moduleState) return;
-  moduleState.arObjects = moduleState.arObjects.filter(
-    (item) => item.id !== arObject.id,
-  );
+  moduleState.arObjects = moduleState.arObjects.filter((item) => item.id !== arObject.id,);
   callARCallback();
 }
 
@@ -265,9 +263,7 @@ export function setFrontObject(arObject: ARObject | undefined) {
 export function getFrontObject() {
   const moduleState = getModuleState();
   if (!moduleState) return undefined;
-  return moduleState.arObjects.find(
-    (arObject) => arObject.id === moduleState.selectedObjectId,
-  );
+  return moduleState.arObjects.find((arObject) => arObject.id === moduleState.selectedObjectId,);
 }
 
 /**

src/bundles/arcade_2d/src/gameobject.ts

@@ -18,9 +18,7 @@ export abstract class GameObject implements Transformable, ReplResult {
   protected isTransformUpdated: boolean = false;
   public readonly id: number;
 
-  constructor(
-    private transformProps: types.TransformProps = DEFAULT_TRANSFORM_PROPS
-  ) {
+  constructor(private transformProps: types.TransformProps = DEFAULT_TRANSFORM_PROPS) {
     this.id = GameObject.gameObjectCount++;
   }
   setTransform(transformProps: types.TransformProps) {

src/bundles/arcade_2d/src/index.ts

@@ -12,21 +12,21 @@
  *
  * ### WASD input example
  * ```
-import { create_rectangle, query_position, update_position, update_loop, build_game, input_key_down } from "arcade_2d";
-
-// Create GameObjects outside update_loop(...)
-const player = update_position(create_rectangle(100, 100), [300, 300]);
-const movement_dist = 10;
-
-function add_vectors(to, from) {
-    to[0] = to[0] + from[0];
-    to[1] = to[1] + from[1];
-}
-
-update_loop(game_state => {
-    const new_position = query_position(player);
-
-    if (input_key_down("w")) {
+ * import { create_rectangle, query_position, update_position, update_loop, build_game, input_key_down } from "arcade_2d";
+ *
+ * // Create GameObjects outside update_loop(...)
+ * const player = update_position(create_rectangle(100, 100), [300, 300]);
+ * const movement_dist = 10;
+ *
+ * function add_vectors(to, from) {
+ * to[0] = to[0] + from[0];
+ * to[1] = to[1] + from[1];
+ * }
+ *
+ * update_loop(game_state => {
+ * const new_position = query_position(player);
+ *
+ * if (input_key_down("w")) {
         add_vectors(new_position, [0, -1 * movement_dist]);
     }
     if (input_key_down("a")) {
@@ -38,7 +38,7 @@ update_loop(game_state => {
     if (input_key_down("d")) {
         add_vectors(new_position, [movement_dist, 0]);
     }
-
+ 
     // Update GameObjects within update_loop(...)
     update_position(player, new_position);
 });
@@ -48,20 +48,20 @@ build_game();
  * ### Draggable objects example
  * ```
 import { create_sprite, update_position, update_scale, pointer_over_gameobject, input_left_mouse_down, update_to_top, query_pointer_position, update_loop, build_game } from "arcade_2d";
-
+ 
 // Using assets
 const gameobjects = [
     update_position(create_sprite("objects/cmr/splendall.png"), [200, 400]),
     update_position(update_scale(create_sprite("avatars/beat/beat.happy.png"), [0.3, 0.3]), [300, 200]),
     update_position(update_scale(create_sprite("avatars/chieftain/chieftain.happy.png"), [0.2, 0.2]), [400, 300])];
-
+ 
 // Simple dragging function
 function drag_gameobject(gameobject) {
    if (input_left_mouse_down() && pointer_over_gameobject(gameobject)) {
        update_to_top(update_position(gameobject, query_pointer_position()));
    }
 }
-
+ 
 update_loop(game_state => {
    for (let i = 0; i < 3; i = i + 1) {
        drag_gameobject(gameobjects[i]);
@@ -73,7 +73,7 @@ build_game();
  * ### Playing audio example
  * ```
 import { input_key_down, create_audio, play_audio, update_loop, build_game } from "arcade_2d";
-
+ 
 const audio = create_audio("https://labs.phaser.io/assets/audio/SoundEffects/key.wav", 1);
 update_loop(game_state => {
     // Press space to play audio
@@ -87,15 +87,15 @@ build_game();
  *
  * ```
 import { create_rectangle, update_position, update_color, get_loop_count, set_scale, update_loop, build_game } from "arcade_2d";
-
+ 
 const gameobjects = [];
 for (let i = 0; i < 100; i = i + 1) {
     gameobjects[i] = [];
     for (let j = 0; j < 100; j = j + 1) {
         gameobjects[i][j] = update_position(create_rectangle(1, 1), [i, j]);
     }
 }
-
+ 
 update_loop(game_state => {
  const k = get_loop_count();
  for (let i = 0; i < 100; i = i + 1) {
@@ -112,31 +112,31 @@ build_game();
  * ```
 import { create_rectangle, create_sprite, create_text, query_position, update_color, update_position, update_scale, update_text, update_to_top, set_fps, get_loop_count, enable_debug, debug_log, input_key_down, gameobjects_overlap, update_loop, build_game, create_audio, loop_audio, stop_audio, play_audio } from "arcade_2d";
 // enable_debug(); // Uncomment this to see debug info
-
+ 
 // Constants
 let snake_length = 4;
 const food_growth = 4;
 set_fps(10);
-
+ 
 const snake = [];
 const size = 600;
 const unit = 30;
 const grid = size / unit;
 const start_length = snake_length;
-
+ 
 // Create Sprite Gameobjects
 update_scale(create_sprite("https://labs.phaser.io/assets/games/germs/background.png"), [4, 4]); // Background
 const food = create_sprite("https://labs.phaser.io/assets/sprites/tomato.png");
 let eaten = true;
-
+ 
 for (let i = 0; i < 1000; i = i + 1) {
     snake[i] = update_color(update_position(create_rectangle(unit, unit), [-unit / 2, -unit / 2]),
         [127 + 128 * math_sin(i / 20), 127 + 128 * math_sin(i / 50), 127 + 128 * math_sin(i / 30), 255]); // Store offscreen
 }
 const snake_head = update_color(update_position(create_rectangle(unit * 0.9, unit * 0.9), [-unit / 2, -unit / 2]), [0, 0, 0 ,0]); // Head
-
+ 
 let move_dir = [unit, 0];
-
+ 
 // Other functions
 const add_vec = (v1, v2) => [v1[0] + v2[0], v1[1] + v2[1]];
 const bound_vec = v => [(v[0] + size) % size, (v[1] + size) % size];
@@ -156,49 +156,49 @@ function input() {
     }
 }
 let alive = true;
-
+ 
 // Create Text Gameobjects
 const score = update_position(create_text("Score: "), [size - 60, 20]);
 const game_text = update_color(update_scale(update_position(create_text(""), [size / 2, size / 2]), [2, 2]), [0, 0, 0, 255]);
-
+ 
 // Audio
 const eat = create_audio("https://labs.phaser.io/assets/audio/SoundEffects/key.wav", 1);
 const lose = create_audio("https://labs.phaser.io/assets/audio/stacker/gamelost.m4a", 1);
 const move = create_audio("https://labs.phaser.io/assets/audio/SoundEffects/alien_death1.wav", 1);
 const bg_audio = play_audio(loop_audio(create_audio("https://labs.phaser.io/assets/audio/tech/bass.mp3", 0.5)));
-
+ 
 // Create Update loop
 update_loop(game_state => {
     update_text(score, "Score: " + stringify(snake_length - start_length));
     if (!alive) {
         update_text(game_text, "Game Over!");
         return undefined;
     }
-
+ 
     // Move snake
     for (let i = snake_length - 1; i > 0; i = i - 1) {
         update_position(snake[i], query_position(snake[i - 1]));
     }
     update_position(snake[0], query_position(snake_head)); // Update head
     update_position(snake_head, bound_vec(add_vec(query_position(snake_head), move_dir))); // Update head
     debug_log(query_position(snake[0])); // Head
-
+ 
     input();
-
+ 
     // Add food
     if (eaten) {
         update_position(food, [math_floor(math_random() * grid) * unit + unit / 2, math_floor(math_random() * grid) * unit + unit / 2]);
         eaten = false;
     }
-
+ 
     // Eat food
     if (get_loop_count() > 1 && gameobjects_overlap(snake_head, food)) {
         eaten = true;
         snake_length = snake_length + food_growth;
         play_audio(eat);
     }
     debug_log(snake_length); // Score
-
+ 
     // Check collision
     if (get_loop_count() > start_length) {
         for (let i = 0; i < snake_length; i = i + 1) {

src/bundles/arcade_2d/src/phaserScene.ts

@@ -201,13 +201,11 @@ export class PhaserScene extends Phaser.Scene {
             shape.radius
           ));
           if (gameObject.getHitboxState().isHitboxActive) {
-            this.phaserGameObjects[gameObject.id].setInteractive(
-              new Phaser.Geom.Circle(
-                shape.radius,
-                shape.radius,
-                shape.radius
-              ), Phaser.Geom.Circle.Contains
-            );
+            this.phaserGameObjects[gameObject.id].setInteractive(new Phaser.Geom.Circle(
+              shape.radius,
+              shape.radius,
+              shape.radius
+            ), Phaser.Geom.Circle.Contains);
           }
         }
         if (gameObject instanceof TriangleGameObject) {
@@ -223,16 +221,14 @@ export class PhaserScene extends Phaser.Scene {
             shape.y3
           ));
           if (gameObject.getHitboxState().isHitboxActive) {
-            this.phaserGameObjects[gameObject.id].setInteractive(
-              new Phaser.Geom.Triangle(
-                shape.x1,
-                shape.y1,
-                shape.x2,
-                shape.y2,
-                shape.x3,
-                shape.y3
-              ), Phaser.Geom.Triangle.Contains
-            );
+            this.phaserGameObjects[gameObject.id].setInteractive(new Phaser.Geom.Triangle(
+              shape.x1,
+              shape.y1,
+              shape.x2,
+              shape.y2,
+              shape.x3,
+              shape.y3
+            ), Phaser.Geom.Triangle.Contains);
           }
         }
       }
@@ -287,9 +283,7 @@ export class PhaserScene extends Phaser.Scene {
         gameState.debugLogArray.push(`${error.name}: ${error.message}`);
       } else {
         const exceptionError = error as ExceptionError;
-        gameState.debugLogArray.push(
-          `Line ${exceptionError.location.start.line}: ${exceptionError.error.name}: ${exceptionError.error.message}`
-        );
+        gameState.debugLogArray.push(`Line ${exceptionError.location.start.line}: ${exceptionError.error.name}: ${exceptionError.error.message}`);
       }
     }
   }