Typed modules #331
Merged
Typed modules #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
reviewed
Feb 25, 2025
Member
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
Hi, just some minor nits, but I've resolved the other comments I had and pushed them onto this branch, do take a look and double-check, thanks! I'm left with the one comment below:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of Typed Modules based on this proof-of-concept and this proposal for the FYP titled "Improving Types in the Source Academy".
Previously, module members are mapped to the
anytype for all variables, function parameters and function return values. This PR enables module authors to define module variables, functions and types inline with TypeScript decorators, enabling the teaching team to teach types more effectively.Currently, only the rune and curve modules are "migrated" from "untyped" to "typed".