Fixed resolver and translator errors (#21)

* scoping rules in resolver implemented

* Uncommented newline handling

* Added display to environment for debugging

* Remove test code from index.ts

---------

Co-authored-by: yizhak <[email protected]>

Author: JJtan2002

src/index.ts

@@ -150,10 +150,6 @@ export function parsePythonToEstreeAst(code: string,
     return translator.resolve(ast) as unknown as Program
 }
 
-const text = `
--1
-`
-console.dir(parsePythonToEstreeAst(text, 1, false));
 export * from './errors';
 
 // import {ParserErrors, ResolverErrors, TokenizerErrors} from "./errors";

src/parser.ts

@@ -141,9 +141,9 @@ export class Parser {
         const startToken = this.peek();
         const statements: Stmt[] = [];
         while (!this.isAtEnd()) {
-            // if (this.match(TokenType.NEWLINE)) {
-            //     continue;
-            // }
+            if (this.match(TokenType.NEWLINE)) {
+                continue;
+            }
             statements.push(this.stmt());
         }
         const endToken = this.peek();

src/resolver.ts

@@ -127,16 +127,18 @@ export class Resolver implements StmtNS.Visitor<void>, ExprNS.Visitor<void> {
     ast: Stmt;
     // change the environment to be suite scope as in python
     environment: Environment | null;
+    functionScope: Environment | null;
     constructor(source: string, ast: Stmt) {
         this.source = source;
         this.ast = ast;
         // The global environment
         this.environment = new Environment(source, null, new Map([
             ["range", new Token(TokenType.NAME, "range", 0, 0, 0)],
-            ["display", new Token(TokenType.NAME, "display", 0, 0, 0)],
+            ["print", new Token(TokenType.NAME, "print", 0, 0, 0)],
             ["stringify", new Token(TokenType.NAME, "stringify", 0, 0, 0)],
             // @TODO add all the source pre-declared names here
         ]));
+        this.functionScope = null;
     }
     resolve(stmt: Stmt[] | Stmt | Expr[] | Expr | null) {
         if (stmt === null) {
@@ -163,6 +165,27 @@ export class Resolver implements StmtNS.Visitor<void>, ExprNS.Visitor<void> {
         return res.length === 0 ? null : res;
     }
 
+    functionVarConstraint(identifier: Token): void {
+        if (this.functionScope == null) {
+            return;
+        }
+        let curr = this.environment;
+        while (curr !== this.functionScope) {
+            if (curr !== null && curr.names.has(identifier.lexeme)) {
+                const token = curr.names.get(identifier.lexeme);
+                if (token === undefined) {
+                    throw new Error("placeholder error")
+                }
+                throw new ResolverErrors.NameReassignmentError(identifier.line, identifier.col,
+                    this.source,
+                    identifier.indexInSource,
+                    identifier.indexInSource + identifier.lexeme.length,
+                    token);
+            }
+            curr = curr?.enclosing ?? null;
+        }
+    }
+
     //// STATEMENTS
     visitFileInputStmt(stmt: StmtNS.FileInput): void {
         // Create a new environment.
@@ -175,8 +198,7 @@ export class Resolver implements StmtNS.Visitor<void>, ExprNS.Visitor<void> {
     }
 
     visitIndentCreation(stmt: StmtNS.Indent): void {
-        // Create a new environment.
-        const oldEnv = this.environment;
+        // Create a new environment
         this.environment = new Environment(this.source, this.environment, new Map());
     }
 
@@ -190,19 +212,20 @@ export class Resolver implements StmtNS.Visitor<void>, ExprNS.Visitor<void> {
     visitFunctionDefStmt(stmt: StmtNS.FunctionDef) {
         this.environment?.declareName(stmt.name);
         this.environment?.functions.add(stmt.name.lexeme);
-        // // Create a new environment.
+        // Create a new environment.
         // const oldEnv = this.environment;
-        // // Assign the parameters to the new environment.
-        // const newEnv = new Map(
-        //     stmt.parameters.map(param => [param.lexeme, param])
-        // );
-        // this.environment = new Environment(this.source, this.environment, newEnv);
-        const params = new Map(
+        // Assign the parameters to the new environment.
+        const newEnv = new Map(
             stmt.parameters.map(param => [param.lexeme, param])
         );
-        if (this.environment !== null) {
-            this.environment.names = params;
-        }
+        this.environment = new Environment(this.source, this.environment, newEnv);
+        // const params = new Map(
+        //     stmt.parameters.map(param => [param.lexeme, param])
+        // );
+        // if (this.environment !== null) {
+        //     this.environment.names = params;
+        // }
+        this.functionScope = this.environment;
         this.resolve(stmt.body);
         // Grab identifiers from that new environment. That are NOT functions.
         // stmt.varDecls = this.varDeclNames(this.environment.names)
@@ -213,11 +236,13 @@ export class Resolver implements StmtNS.Visitor<void>, ExprNS.Visitor<void> {
     visitAnnAssignStmt(stmt: StmtNS.AnnAssign): void {
         this.resolve(stmt.ann);
         this.resolve(stmt.value);
+        this.functionVarConstraint(stmt.name);
         this.environment?.declareName(stmt.name);
     }
 
     visitAssignStmt(stmt: StmtNS.Assign): void {
         this.resolve(stmt.value);
+        this.functionVarConstraint(stmt.name);
         this.environment?.declareName(stmt.name);
     }
 

src/translator.ts

@@ -41,6 +41,7 @@ import {
     WhileStatement
 } from "estree";
 import { TranslatorErrors } from "./errors";
+// import { isEmpty } from "lodash";
 
 export interface EstreePosition {
     line: number;
@@ -193,6 +194,20 @@ export class Translator implements StmtNS.Visitor<BaseNode>, ExprNS.Visitor<Base
         };
     }
 
+    visitIndentCreation(stmt: StmtNS.Indent): EmptyStatement {
+        return {
+            type: 'EmptyStatement',
+            loc: this.toEstreeLocation(stmt),
+        };
+    }
+
+    visitDedentCreation(stmt: StmtNS.Dedent): EmptyStatement {
+        return {
+            type: 'EmptyStatement',
+            loc: this.toEstreeLocation(stmt),
+        };
+    }
+
     visitFunctionDefStmt(stmt: StmtNS.FunctionDef): FunctionDeclaration {
         const newBody = this.resolveManyStmt(stmt.body);
         // if (stmt.varDecls !== null && stmt.varDecls.length > 0) {