moved constants to config.ts

Author: yihao03

i18n/config.ts

@@ -0,0 +1,8 @@
+// maximum permissible concurrent translations
+const max_trans_num = Number(process.env.MAX_TRANSLATION_NO) || 5;
+
+// log file configs
+const translationSummaryPrefix = "translation-summary";
+const jsonSummaryPrefix = "json-summary";
+
+export {max_trans_num, translationSummaryPrefix, jsonSummaryPrefix}

i18n/index.ts

@@ -1,18 +1,19 @@
 import PathGenerator from "./controllers/path.ts";
 import translate, { getFileErrors } from "./controllers/recurTranslate.ts";
-import fs from "fs";
+import fs, { Dirent } from "fs";
 import util from "util";
 import path from "path";
 import { fileURLToPath } from "url";
 import { dirname } from "path";
 import OpenAI from "openai";
+import { max_trans_num, translationSummaryPrefix } from "./config.ts";
 
 // Get the directory name of the current module
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 
 const readdir = util.promisify(fs.readdir);
-const getDirectories = async source =>
+const getDirectories = async (source: fs.PathLike) =>
   (await readdir(source, { withFileTypes: true }))
     .filter(dirent => dirent.isDirectory())
     .map(dirent => dirent.name);
@@ -26,8 +27,6 @@ let failureCount = 0;
 let processedCount = 0;
 let failures: { file: string; error: any }[] = [];
 
-const max_trans_num = Number(process.env.MAX_TRANSLATION_NO) || 5;
-
 // Function to save summary log - can be called from signal handlers
 async function saveSummaryLog() {
   try {
@@ -115,7 +114,7 @@ Success rate: ${filesToTranslate.length > 0 ? ((successCount / filesToTranslate.
       fs.mkdirSync(logDir, { recursive: true });
     }
 
-    const logPath = path.join(logDir, `translation-summary-${timestamp}.log`);
+    const logPath = path.join(logDir, `${translationSummaryPrefix}-${timestamp}.log`);
     fs.writeFileSync(logPath, summaryLog);
     console.log(
       `Summary log saved to logs/translation-summary-${timestamp}.log`
@@ -190,7 +189,7 @@ async function needsTranslation(
     const enStats = await fs.promises.stat(enFilePath);
     return enStats.mtime > cnStats.mtime;
   } catch (error) {
-    return true;
+    throw error;
   }
 }
 
@@ -313,7 +312,6 @@ export default async function fancyName(path: string, language: string) {
             if (result.value.success) {
               successCount++;
             } else {
-              failureCount++;
               failures.push({
                 file: result.value.file,
                 error: result.value.error
@@ -324,7 +322,6 @@ export default async function fancyName(path: string, language: string) {
             }
           } else {
             // This is for Promise rejections (should be rare with our error handling)
-            failureCount++;
             failures.push({
               file: "Unknown file in batch",
               error: result.reason

javascript/index.js

@@ -37,15 +37,12 @@ import { setupSnippetsJs } from "./processingFunctions/processSnippetJs";
 import { getAnswers } from "./processingFunctions/processExercisePdf";
 
 // json (for cadet frontend)
-import { testIndexSearch } from "./searchRewriteTest";
 import { parseXmlJson } from "./parseXmlJson";
 import { writeRewritedSearchData } from "./searchRewrite";
 import { setupSnippetsJson } from "./processingFunctions/processSnippetJson";
 import { createTocJson } from "./generateTocJson";
 import { setupReferencesJson } from "./processingFunctions/processReferenceJson";
-import { SourceTextModule } from "vm";
-import { threadId } from "worker_threads";
-import { exitCode } from "process";
+import { jsonSummaryPrefix } from "../i18n/config";
 
 export let parseType;
 let version;
@@ -407,10 +404,10 @@ async function main() {
       fs.mkdirSync(logDir, { recursive: true });
     }
 
-    const logPath = path.join(logDir, `json-summary-${timestamp}.log`);
+    const logPath = path.join(logDir, `${jsonSummaryPrefix}-${timestamp}.log`);
     fs.writeFileSync(logPath, summaryLog);
     console.log(
-      `Summary log saved to logs/translation-summary-${timestamp}.log`
+      `Summary log saved to logs/json-summary-${timestamp}.log`
     );
   } catch (logError) {
     console.error("Failed to save log file:", logError);