replace MAXLEN with max_chunk_len according to code review

Author: coder114514

i18n/controllers/loggers.ts

@@ -3,6 +3,11 @@ import path from "path";
 import fs from "fs";
 import { getFileErrors } from "./translator";
 import { translationSummaryPrefix } from "../config";
+import { fileURLToPath } from "url";
+import { dirname } from "path";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
 
 // Function to save summary log - can be called from signal handlers
 export async function saveSummaryLog(
@@ -103,7 +108,7 @@ Success rate: ${translateNum > 0 ? ((successCount / translateNum) * 100).toFixed
         );
         fs.writeFileSync(logPath, summaryLog);
         console.log(
-            `Summary log saved to logs/translation-summary-${timestamp}.log`
+            `Summary log saved to i18n/logs/${translationSummaryPrefix}-${timestamp}.log`
         );
     } catch (logError) {
         console.error("Failed to save log file:", logError);

i18n/controllers/parsers.ts

@@ -3,9 +3,7 @@ import { escapeXML, formatAttributes, strongEscapeXML } from "./xmlUtilities";
 import { Readable } from "stream";
 import { ignoredTags, max_chunk_len } from "../config";
 import fs, { PathLike } from "fs";
-import { FileLike } from "openai/uploads.mjs";
 
-const MAXLEN = max_chunk_len;
 const createParser = () =>
   (sax as any).createStream(false, { trim: false }, { strictEntities: true });
 
@@ -140,7 +138,7 @@ export async function splitParser(
             segments.length > 0 &&
             segments[segments.length - 1][0] &&
             segments[segments.length - 1][1].length + currentSegment.length <
-              Number(MAXLEN)
+              max_chunk_len
           ) {
             segments[segments.length - 1][1] += currentSegment;
           } else {
@@ -264,7 +262,7 @@ export async function recurSplitParser(
           subSegments[subSegments.length - 1][0] &&
           subSegments[subSegments.length - 1][1].length +
             subCurrentSegment.length <
-            Number(MAXLEN)
+            max_chunk_len
         ) {
           subSegments[subSegments.length - 1][1] += subCurrentSegment;
         } else {

i18n/controllers/translator.ts

@@ -5,6 +5,7 @@ import createAssistant from "../initializers/initialize";
 import dotenv from "dotenv";
 import sax from "sax";
 import { cleanParser, recurSplitParser, splitParser } from "./parsers";
+import { max_chunk_len } from "../config";
 
 dotenv.config();
 
@@ -18,8 +19,6 @@ const ai = new OpenAI({
   baseURL: process.env.AI_BASEURL
 });
 
-const MAXLEN = Number(process.env.MAX_LEN) || 3000;
-
 // change to true to avoid calling openai api, useful for troubleshooting
 // chunking logic
 const troubleshoot = false;
@@ -126,7 +125,7 @@ async function recursivelyTranslate(
 ): Promise<string> {
   // Recursive function to split and translate
   async function helper(ori: string): Promise<string> {
-    if (ori.length < MAXLEN) {
+    if (ori.length < max_chunk_len) {
       return await translateChunk(ori); // translate the chunk
     }