Skip to content

Commit 239e612

Browse files
committed
refactor method name
1 parent af70172 commit 239e612

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

src/slice/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ def headerData(self, section, orientation, role):
213213
# add full registered axis strings in tooltips
214214
if role == Qt.ToolTipRole:
215215
if orientation == Qt.Vertical:
216-
axis_name = self.get_registered_axis_string(self._v_header[section])
216+
axis_name = self.get_axis_name_string(self._v_header[section])
217217
# if this is a defined registered axis value, create a tooltip
218218
# with the full axis name
219219
if axis_name:
@@ -295,7 +295,7 @@ def get_default_axis_value(self, axistag):
295295
else:
296296
return None
297297

298-
def get_registered_axis_string(self, needle):
298+
def get_axis_name_string(self, needle):
299299
registered_axes = {
300300
"ital": "Italic",
301301
"opsz": "Optical size",

tests/test_models_designaxis.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def test_designaxis_model_filled(qtbot, qtmodeltester):
2929
qtmodeltester.check(model)
3030

3131
# confirm that font data loaded appropriately
32-
assert model._h_header == ["(Min, Max) [Default]", "Instance Values"]
32+
assert model._h_header == ["(Min, Max) [Default]", "Edit Values"]
3333
assert model.ordered_axis_tags == ["MONO", "CASL", "wght", "slnt", "CRSV"]
3434
assert model._v_header == ["MONO", "CASL", "wght", "slnt", "CRSV"]
3535
assert model.fvar_axes == {
@@ -146,28 +146,28 @@ def test_designaxis_model_get_default_axis_value(qtbot):
146146
assert model.get_default_axis_value("CRSV") == 0.5
147147

148148

149-
def test_designaxis_model_get_registered_axis_string(qtbot):
149+
def test_designaxis_model_get_axis_name_string(qtbot):
150150
tableview = QTableView()
151151
model = DesignAxisModel()
152152
tableview.setModel(model)
153153
qtbot.addWidget(tableview)
154154
model.load_font(get_font_model())
155155

156156
# registered axes
157-
assert model.get_registered_axis_string("ital") == "Italic"
158-
assert model.get_registered_axis_string("opsz") == "Optical size"
159-
assert model.get_registered_axis_string("slnt") == "Slant"
160-
assert model.get_registered_axis_string("wdth") == "Width"
161-
assert model.get_registered_axis_string("wght") == "Weight"
157+
assert model.get_axis_name_string("ital") == "Italic"
158+
assert model.get_axis_name_string("opsz") == "Optical size"
159+
assert model.get_axis_name_string("slnt") == "Slant"
160+
assert model.get_axis_name_string("wdth") == "Width"
161+
assert model.get_axis_name_string("wght") == "Weight"
162162

163163
# unregistered axes
164-
assert model.get_registered_axis_string("CASL") == "Casual"
165-
assert model.get_registered_axis_string("CRSV") == "Cursive"
166-
assert model.get_registered_axis_string("XPRN") == "Expression"
167-
assert model.get_registered_axis_string("GRAD") == "Grade"
168-
assert model.get_registered_axis_string("MONO") == "Monospace"
169-
assert model.get_registered_axis_string("SOFT") == "Softness"
170-
assert model.get_registered_axis_string("WONK") == "Wonky"
164+
assert model.get_axis_name_string("CASL") == "Casual"
165+
assert model.get_axis_name_string("CRSV") == "Cursive"
166+
assert model.get_axis_name_string("XPRN") == "Expression"
167+
assert model.get_axis_name_string("GRAD") == "Grade"
168+
assert model.get_axis_name_string("MONO") == "Monospace"
169+
assert model.get_axis_name_string("SOFT") == "Softness"
170+
assert model.get_axis_name_string("WONK") == "Wonky"
171171

172172
# not a known (to this application) axis tag
173-
assert model.get_registered_axis_string("ZXYJ") is None
173+
assert model.get_axis_name_string("ZXYJ") is None

0 commit comments

Comments
 (0)