add qtmodeltester and SliceBaseTableModel, DesignAxisModel fixes

Author: chrissimpkins

src/slice/models.py

@@ -36,10 +36,22 @@ def setData(self, index, value, role):
             return False
 
     def rowCount(self, index):
-        return len(self._data)
+        # the index validity check approach addresses the qabstractitemmodel.cpp check:
+        # QtWarningMsg: FAIL! model->hasChildren(topIndex) () returned FALSE (qabstractitemmodeltester.cpp:366)
+        # See https://stackoverflow.com/a/50988188/2848172
+        if index.isValid():
+            return 0
+        else:
+            return len(self._data)
 
     def columnCount(self, index):
-        return len(self._data[0])
+        # the index validity check approach addresses the qabstractitemmodel.cpp check:
+        # QtWarningMsg: FAIL! model->hasChildren(topIndex) () returned FALSE (qabstractitemmodeltester.cpp:366)
+        # See https://stackoverflow.com/a/50988188/2848172
+        if index.isValid():
+            return 0
+        else:
+            return len(self._data[0])
 
     def get_data(self):
         return self._data
@@ -193,13 +205,18 @@ def headerData(self, section, orientation, role):
             return self._h_header[section]
 
     def flags(self, index):
+        # Note: index validity checks in this block address qabstractitemmodeltester error:
+        # QtWarningMsg: FAIL! flags == Qt::ItemIsDropEnabled || flags == 0 () returned FALSE (qabstractitemmodeltester.cpp:329)
+
         # column 0 (axis value range and default) is set
         # to non-editable
-        if index.column() == 0:
+        if index.isValid() and index.column() == 0:
             return super().flags(index) | Qt.ItemIsSelectable
         # column 1 (instance value) is set to editable
-        else:
+        elif index.isValid() and index.column() == 1:
             return super().flags(index) | Qt.ItemIsEditable
+        else:
+            return super().flags(index)
 
     def load_font(self, font_model):
         ttfont = TTFont(font_model.fontpath)

tests/test_models.py

@@ -0,0 +1,23 @@
+import pytest
+
+from PyQt5.QtWidgets import QTableView
+
+from slice.models import DesignAxisModel, FontModel, FontBitFlagModel, FontNameModel
+
+
+def test_font_model():
+    fm = FontModel("testpath")
+    assert fm.fontpath == "testpath"
+
+
+def test_designaxis_model_default(qtbot, qtmodeltester):
+    tableview = QTableView()
+    model = DesignAxisModel()
+    tableview.setModel(model)
+    qtbot.addWidget(tableview)
+    # check model with default instantiation
+    qtmodeltester.check(model)
+
+
+def test_designaxis_model_filled(qtbot, qtmodeltester):
+    pass