Skip to content

Commit a5434e5

Browse files
committed
refactor axis editor data method name
1 parent 9f983fd commit a5434e5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/slice/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ def btn_clicked_slice(self):
551551
self.statusbar.update()
552552
# must keep this return statement to abort execution!
553553
return
554-
elif not self.fvar_table_model.instance_data_validates():
554+
elif not self.fvar_table_model.instance_data_validates_missing_data():
555555
SliceErrorDialog(
556556
"You requested the same design space that is supported in the "
557557
"font path that you are processing. Please define at least one "

src/slice/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ def get_instance_data(self):
293293

294294
return instance_data
295295

296-
def instance_data_validates(self):
296+
def instance_data_validates_missing_data(self):
297297
# validator that returns True if there is at least one
298298
# axis tag with a defined instance, and False if all
299299
# axis tags have blank entry fields = the original variable

tests/test_models_designaxis.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def test_designaxis_model_get_partial_instance_data(qtbot):
112112
}
113113

114114

115-
def test_designaxis_model_instance_data_validates(qtbot):
115+
def test_designaxis_model_instance_data_validates_missing_data(qtbot):
116116
tableview = QTableView()
117117
model = DesignAxisModel()
118118
tableview.setModel(model)
@@ -125,7 +125,7 @@ def test_designaxis_model_instance_data_validates(qtbot):
125125
# variable
126126
assert model.get_instance_data() == {}
127127

128-
assert model.instance_data_validates() is False
128+
assert model.instance_data_validates_missing_data() is False
129129

130130
# fill model and try again
131131
# this requires at least one axis to have a value
@@ -136,7 +136,7 @@ def test_designaxis_model_instance_data_validates(qtbot):
136136
model._data[4][1] = ""
137137
model.layoutChanged.emit()
138138

139-
assert model.instance_data_validates() is True
139+
assert model.instance_data_validates_missing_data() is True
140140

141141

142142
def test_designaxis_model_get_number_of_axes(qtbot):

0 commit comments

Comments
 (0)