removed test for typo_descender value, should never be defined in way that was tested

Author: chrissimpkins

lib/fontline/app.py

@@ -20,6 +20,7 @@
 # TODO: support integer addition and subtraction to the linegap value through new sub-commands
 # TODO: support .woff and .woff2 file types?
 # TODO: JSON formatted metrics output
+# TODO: autocorrect command?
 
 
 def main():
@@ -81,7 +82,7 @@ def main():
                         if modify_linegap_percent(fontpath, percent) is True:
                             outpath = get_linegap_percent_filepath(fontpath, percent)
                             stdout("[font-line] '" + fontpath + "' successfully modified to '" + outpath + "'.")
-                        else:
+                        else:  # pragma: no cover
                             stderr("[font-line] ERROR: Unsuccessful modification of '" + fontpath + "'.")
                     else:
                         stderr("[font-line] ERROR: '" + fontpath + "' does not appear to be a supported font file type.")

lib/fontline/commands.py

@@ -78,12 +78,8 @@ def modify_linegap_percent(fontpath, percent):
 
         factor = 1.0 * int(percent) / 100
 
-        if os2_typo_descender < 0:
-            os2_typo_linegap = int(factor * (os2_typo_ascender + -(os2_typo_descender)))
-            total_height = os2_typo_ascender + -(os2_typo_descender) + os2_typo_linegap
-        else:
-            os2_typo_linegap = int(factor * (os2_typo_ascender + os2_typo_descender))
-            total_height = os2_typo_ascender + os2_typo_descender + os2_typo_linegap
+        os2_typo_linegap = int(factor * (os2_typo_ascender + -(os2_typo_descender)))
+        total_height = os2_typo_ascender + -(os2_typo_descender) + os2_typo_linegap
 
         hhea_ascent = int(os2_typo_ascender + 0.5 * os2_typo_linegap)
         hhea_descent = -(total_height - hhea_ascent)
@@ -101,7 +97,7 @@ def modify_linegap_percent(fontpath, percent):
 
         tt.save(get_linegap_percent_filepath(fontpath, percent))
         return True
-    except Exception as e:
+    except Exception as e:  # pragma: no cover
         stderr("[font-line] ERROR: Unable to modify the line spacing in the font file '" + fontpath + "'. " + str(e))
         sys.exit(1)