minor updates in aws route config

Author: opensource4learn

modules/security-groups/main.tf

@@ -1,15 +1,4 @@
 # AWS Public Security Group
-# module "public_security_group" {
-#   source              = "./resources"
-#   count               = var.cluster_architecture == "1-tier" || var.cluster_architecture == "2-tier" || var.cluster_architecture == "3-tier" ? 1 : 0
-#   vpc_id              = var.vpc_id
-#   cluster_prefix      = var.cluster_prefix
-#   cluster_environment = var.cluster_environment
-#   sg_type             = "public"
-#   sg_description      = "Allow connections from internet"
-#   cluster_architecture  = var.cluster_architecture
-# }
-
 resource "aws_security_group" "public_security_group" {
   count                  = var.cluster_architecture == "1-tier" || var.cluster_architecture == "2-tier" || var.cluster_architecture == "3-tier" ? 1 : 0
   name                   = "${var.cluster_prefix}-public"
@@ -68,17 +57,6 @@ resource "aws_security_group" "public_security_group" {
 # }
 
 # AWS Private Security Group
-# module "private_security_group" {
-#   source              = "./resources"
-#   count                = var.cluster_architecture == "2-tier" || var.cluster_architecture == "3-tier" ? 1 : 0
-#   vpc_id              = var.vpc_id
-#   cluster_prefix      = var.cluster_prefix
-#   cluster_environment = var.cluster_environment
-#   sg_type             = "private"
-#   sg_description      = "The private security group to allows inbound traffic from public group"
-#   cluster_architecture  = var.cluster_architecture
-# }
-
 resource "aws_security_group" "private_security_group" {
   count                  = var.cluster_architecture == "2-tier" || var.cluster_architecture == "3-tier" ? 1 : 0
   name                   = "${var.cluster_prefix}-private"
@@ -112,17 +90,6 @@ resource "aws_security_group_rule" "allow_inbound_private" {
 }
 
 # AWS Storage Security Group
-# module "storage_security_group" {
-#   source              = "./resources"
-#   count                = var.cluster_architecture == "3-tier" ? 1 : 0
-#   vpc_id              = var.vpc_id
-#   cluster_prefix      = var.cluster_prefix
-#   cluster_environment = var.cluster_environment
-#   sg_type             = "storage"
-#   sg_description      = "The storage security group to allows inbound traffic from private group"
-#   cluster_architecture  = var.cluster_architecture
-# }
-
 resource "aws_security_group" "storage_security_group" {
   count                  = var.cluster_architecture == "3-tier" ? 1 : 0
   name                   = "${var.cluster_prefix}-storage"
@@ -153,4 +120,4 @@ resource "aws_security_group_rule" "allow_inbound_storage" {
   protocol                 = "-1"
   source_security_group_id = aws_security_group.private_security_group[0].id
   security_group_id        = aws_security_group.storage_security_group[0].id
-}
+}

modules/security-groups/output.tf

@@ -1,11 +1,3 @@
-output "public_security_group_ids" {
-  value = aws_security_group.public_security_group.*.id
+output "public_security_group_id" {
+  value = aws_security_group.public_security_group[0].id
 }
-
-output "private_security_group_ids" {
-  value = aws_security_group.private_security_group.*.id
-}
-
-output "storage_security_group_ids" {
-  value = aws_security_group.storage_security_group.*.id
-}

modules/subnets/main.tf

@@ -55,7 +55,7 @@ resource "aws_route" "public_route" {
 
 # AWS Route Tables - Private Route
 resource "aws_route" "private_route" {
-  count                  = var.cluster_architecture == "2-tier" || var.cluster_architecture == "3-tier" && contains(var.subnet_type, "private") ? length(data.aws_availability_zones.available_zones.names) : 0
+  count                  = var.cluster_architecture == "3-tier" && contains(var.subnet_type, "private") ? length(data.aws_availability_zones.available_zones.names) : 0
   route_table_id         = module.aws_private_subnet.route_table_ids[count.index]
   destination_cidr_block = "0.0.0.0/0"
   nat_gateway_id         = var.aws_nat_gateway_id[0]