Skip to content

Commit bd4cc9f

Browse files
authored
do not double post candidate type (#515)
1 parent 9b0ce53 commit bd4cc9f

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

src/bot/__tests__/acceptReviewRequest.test.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,6 @@ describe('acceptReviewRequest', () => {
2020
activeReviewRepo.getReviewByThreadIdOrUndefined = jest.fn();
2121
});
2222

23-
const expectedCandidateTypeBlock = {
24-
type: 'section',
25-
text: {
26-
type: 'mrkdwn',
27-
text: '*Candidate Type:* Full-time',
28-
},
29-
};
3023
const expectedHackerRankUrlBlock = {
3124
type: 'section',
3225
text: {
@@ -141,7 +134,6 @@ describe('acceptReviewRequest', () => {
141134
);
142135
expectUpdatedWithBlocks(
143136
action,
144-
expectedCandidateTypeBlock,
145137
expectedHackerRankUrlBlock,
146138
expectedHackerRankInstructionsBlock,
147139
expectedHackerRankAccountHelpBlock,

src/bot/acceptReviewRequest.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { ActionParam } from '@/slackTypes';
22
import { App } from '@slack/bolt';
33
import log from '@utils/log';
4-
import { ActionId, BlockId, CandidateTypeLabel } from './enums';
4+
import { ActionId, BlockId } from './enums';
55
import { userRepo } from '@repos/userRepo';
66
import { mention, textBlock } from '@utils/text';
77
import { reportErrorAndContinue } from '@utils/reportError';
@@ -86,9 +86,6 @@ export const acceptReviewRequest = {
8686
// Add HackerRank URL with instructions if available
8787
const review = await activeReviewRepo.getReviewByThreadIdOrUndefined(threadId);
8888
if (review) {
89-
blocks.push(
90-
textBlock(`*Candidate Type:* ${CandidateTypeLabel.get(review.candidateType)}`),
91-
);
9289
blocks.push(
9390
textBlock(`*HackerRank Report:* <${review.hackerRankUrl}|View Candidate Assessment>`),
9491
);

0 commit comments

Comments
 (0)