Merge pull request #357 from sourcebots/ruff-fix

Fix ruff rule update

Author: WillB97

pyproject.toml

@@ -107,7 +107,7 @@ Documentation = "https://docs.sourcebots.co.uk"
 [project.optional-dependencies]
 dev = [
     "poethepoet >=0.0.1,<1",
-    "ruff >=0.9,<1",
+    "ruff==0.9.8",
     "mypy==1.10.0; python_version<'3.9'",
     "mypy>=1.7,<2; python_version>='3.9'",
     "build",

sbot/historic/arduino.py

@@ -131,7 +131,7 @@ def _get_simulator_boards(cls) -> MappingProxyType[str, Arduino]:
                     f"Board returned type {err.returned_type!r}, "
                     f"expected {err.expected_type!r}. Ignoring this device")
                 continue
-            boards[board._identity.asset_tag] = board  # noqa: SLF001
+            boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @classmethod
@@ -167,7 +167,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
 
         # Add any manually specified boards
         if isinstance(manual_boards, list):
@@ -190,7 +190,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @log_to_debug

sbot/historic/motor_board.py

@@ -130,7 +130,7 @@ def _get_simulator_boards(cls) -> MappingProxyType[str, MotorBoard]:
                     f"Board returned type {err.returned_type!r}, "
                     f"expected {err.expected_type!r}. Ignoring this device")
                 continue
-            boards[board._identity.asset_tag] = board  # noqa: SLF001
+            boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @classmethod
@@ -170,7 +170,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
 
         # Add any manually specified boards
         if isinstance(manual_boards, list):
@@ -193,7 +193,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @property

sbot/historic/power_board.py

@@ -148,7 +148,7 @@ def _get_simulator_boards(cls) -> MappingProxyType[str, PowerBoard]:
                     f"Board returned type {err.returned_type!r}, "
                     f"expected {err.expected_type!r}. Ignoring this device")
                 continue
-            boards[board._identity.asset_tag] = board  # noqa: SLF001
+            boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @classmethod
@@ -186,7 +186,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
 
         # Add any manually specified boards
         if isinstance(manual_boards, list):
@@ -209,7 +209,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @property

sbot/historic/servo_board.py

@@ -126,7 +126,7 @@ def _get_simulator_boards(cls) -> MappingProxyType[str, ServoBoard]:
                     f"Board returned type {err.returned_type!r}, "
                     f"expected {err.expected_type!r}. Ignoring this device")
                 continue
-            boards[board._identity.asset_tag] = board  # noqa: SLF001
+            boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @classmethod
@@ -165,7 +165,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
 
         # Add any manually specified boards
         if isinstance(manual_boards, list):
@@ -188,7 +188,7 @@ def _get_supported_boards(
                         f"Board returned type {err.returned_type!r}, "
                         f"expected {err.expected_type!r}. Ignoring this device")
                     continue
-                boards[board._identity.asset_tag] = board  # noqa: SLF001
+                boards[board._identity.asset_tag] = board
         return MappingProxyType(boards)
 
     @property