[BUGFIX] Fix the logic for resolving PHP binary. If the binary specified by php_version or composer.json is not found, it now gracefully falls back to search for php binary and finally defaults to plain php.

Author: kszymukowicz

CHANGELOG.rst

@@ -7,7 +7,9 @@ master
 
 1) [FEATURE] Add dbCodeFilter option to filter database (credits to `SimonVanacco <https://github.com/SimonVanacco>`_ )
 2) [BUGFIX] SSL options in drop tables command (credits to `maikschneider <https://github.com/maikschneider>`_ )
-3) [BUGFIX] Make strict boolean conditions for `post_sql_in_markers` and `post_sql_in`.
+3) [BUGFIX] Make strict boolean conditions for ``post_sql_in_markers`` and ``post_sql_in``.
+4) [BUGFIX] Fix the logic for resolving PHP binary. If the binary specified by ``php_version`` or ``composer.json``
+   is not found, it now gracefully falls back to search for ``php`` binary and finally defaults to plain ``php``.
 
 20.0.1
 ------

deployer/db/config/set.php

@@ -136,18 +136,24 @@
 });
 
 set('local/bin/php', function () {
+    $rawPhpVersion = null;
     if (currentHost()->hasOwn('php_version')) {
         $rawPhpVersion = get('php_version');
     }
 
     if (empty($rawPhpVersion) && file_exists('composer.json')) {
-        $composerJson = json_decode(file_get_contents('composer.json'), true);
-
-        if (isset($composerJson['config']['platform']['php'])) {
-            $rawPhpVersion = $composerJson['config']['platform']['php'];
-        }
-        if (empty($rawPhpVersion) && isset($composerJson['require']['php'])) {
-            $rawPhpVersion = $composerJson['require']['php'];
+        try {
+            $composerJson = json_decode(file_get_contents('composer.json'), true);
+            if (is_array($composerJson)) {
+                if (isset($composerJson['config']['platform']['php'])) {
+                    $rawPhpVersion = $composerJson['config']['platform']['php'];
+                }
+                if (empty($rawPhpVersion) && isset($composerJson['require']['php'])) {
+                    $rawPhpVersion = $composerJson['require']['php'];
+                }
+            }
+        } catch (\Throwable $e) {
+            // Silently handle any errors reading composer.json
         }
     }
 
@@ -159,13 +165,68 @@
     }
 
     $fileUtility = new FileUtility();
-    if ($phpVersionMajorMinor) {
+    if ($phpVersionMajorMinor !== null) {
         try {
             return $fileUtility->locateLocalBinaryPath('php' . $phpVersionMajorMinor);
         } catch (\Throwable $e) {
-            return $fileUtility->locateLocalBinaryPath('php' . str_replace('.', '', $phpVersionMajorMinor));
+            try {
+                return $fileUtility->locateLocalBinaryPath('php' . str_replace('.', '', $phpVersionMajorMinor));
+            } catch (\Throwable $e) {
+                output()->writeln(
+                    '<comment>PHP binary with version ' . $phpVersionMajorMinor . ' not found, falling back to search for "php"</comment>',
+                    \Symfony\Component\Console\Output\OutputInterface::VERBOSITY_VERBOSE
+                );
+            }
         }
     }
 
-    return $fileUtility->locateLocalBinaryPath('php');
+    try {
+        $phpBinaryPath = $fileUtility->locateLocalBinaryPath('php');
+        $actualVersionMajorMinor = trim(runLocally($phpBinaryPath . ' -r "echo PHP_MAJOR_VERSION.\".\" . PHP_MINOR_VERSION;"'));
+
+        if ($phpVersionMajorMinor !== null && $actualVersionMajorMinor !== $phpVersionMajorMinor) {
+            $phpVersionStrict = get('php_version_strict', false);
+            if ($phpVersionStrict) {
+                throw new \RuntimeException(sprintf(
+                    'PHP version mismatch: required %s, found %s',
+                    $phpVersionMajorMinor,
+                    $actualVersionMajorMinor
+                ), 1715438658);
+            }
+            output()->writeln(
+                '<warning>Found PHP binary version (' . $phpBinaryPath . ' ' . $actualVersionMajorMinor . ') does not match required version (' . $phpVersionMajorMinor . ')</warning>',
+                \Symfony\Component\Console\Output\OutputInterface::VERBOSITY_NORMAL
+            );
+        }
+        return $phpBinaryPath;
+    } catch (\Throwable $e) {
+        if ($e->getCode() === 1715438658) {
+            throw $e;
+        }
+
+        output()->writeln(
+            '<comment>"php" command not found in PATH, using just "php" directly</comment>',
+            \Symfony\Component\Console\Output\OutputInterface::VERBOSITY_VERBOSE
+        );
+        $phpBinaryPath = 'php';
+        if ($phpVersionMajorMinor !== null) {
+            $actualVersionMajorMinor = trim(runLocally($phpBinaryPath . ' -r "echo PHP_MAJOR_VERSION.\".\" . PHP_MINOR_VERSION;"'));
+
+            if ($actualVersionMajorMinor !== $phpVersionMajorMinor) {
+                $phpVersionStrict = get('php_version_strict', false);
+                if ($phpVersionStrict) {
+                    throw new \RuntimeException(sprintf(
+                        'PHP version mismatch: required %s, found %s',
+                        $phpVersionMajorMinor,
+                        $actualVersionMajorMinor
+                    ), 1715438658);
+                }
+                output()->writeln(
+                    '<warning>PHP version found when running just "php" directly ( ' . $actualVersionMajorMinor . ') does not match required version (' . $phpVersionMajorMinor . ')</warning>',
+                    \Symfony\Component\Console\Output\OutputInterface::VERBOSITY_NORMAL
+                );
+            }
+        }
+        return $phpBinaryPath;
+    }
 });