[BUGFIX] Resolve caching issues on TYPO3 v13

Because of breaking change in core (#102932) following exception was thrown: "Setup array has not been initialized. This happens in cached Frontend scope where full TypoScript is not needed by the system"

Previous solution to change page cache identifier (hash base) was not applied anymore and had to be moved into event listener.

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-102932-RemovedTypoScriptFrontendControllerHooks.html

Author: klamparski

Classes/EventListener/EnrichPageCacheIdentifierParametersEventListener.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SourceBroker\T3api\EventListener;
+
+use SourceBroker\T3api\Service\RouteService;
+use TYPO3\CMS\Frontend\Event\BeforePageCacheIdentifierIsHashedEvent;
+
+/**
+ * We add random value to page cache identifier parameters ("hash base") to protect against full page cache which causes at least two known issues in production environment:
+ * 1. Extbase framework configuration is not loaded thus tables mapping is unknown and queries to not existing database tables may be done.
+ * 2. Links generated using link handler are not build correctly.
+ * 3. Error (Since TYPO3 v13): "Setup array has not been initialized. This happens in cached Frontend scope where full TypoScript is not needed by the system"
+ */
+class EnrichPageCacheIdentifierParametersEventListener
+{
+    public function __invoke(BeforePageCacheIdentifierIsHashedEvent $beforePageCacheIdentifierIsHashedEvent): void
+    {
+        if (!RouteService::routeHasT3ApiResourceEnhancerQueryParam()) {
+            return;
+        }
+
+        $beforePageCacheIdentifierIsHashedEvent->setPageCacheIdentifierParameters([
+            ...$beforePageCacheIdentifierIsHashedEvent->getPageCacheIdentifierParameters(),
+            't3api_hash_base_random' => microtime(),
+        ]);
+    }
+}

Configuration/Services.yaml

@@ -134,3 +134,9 @@ services:
       - name: event.listener
         identifier: 't3api/SetStoragePidForSnapshot'
         event: SourceBroker\T3api\Event\AfterCreateContextForOperationEvent
+
+  SourceBroker\T3api\EventListener\EnrichPageCacheIdentifierParametersEventListener:
+    tags:
+      - name: event.listener
+        identifier: 't3api/EnrichPageCacheIdentifierParametersEventListener'
+        event: TYPO3\CMS\Frontend\Event\BeforePageCacheIdentifierIsHashedEvent

ext_emconf.php

@@ -8,7 +8,7 @@
     'author' => 'Inscript Team',
     'author_email' => '[email protected]',
     'state' => 'stable',
-    'version' => '4.0.3',
+    'version' => '4.1.1',
     'constraints' => [
         'depends' => [
             'php' => '8.1.0-8.3.99',

ext_localconf.php

@@ -118,9 +118,6 @@ static function () {
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['clearCachePostProc']['t3api_clearcache'] =
             \SourceBroker\T3api\Service\SerializerService::class . '->clearCache';
 
-        $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['createHashBase']['t3api'] =
-            \SourceBroker\T3api\Hook\EnrichHashBase::class . '->init';
-
         $GLOBALS['TYPO3_CONF_VARS']['SYS']['routing']['enhancers'][\SourceBroker\T3api\Routing\Enhancer\ResourceEnhancer::ENHANCER_NAME] = \SourceBroker\T3api\Routing\Enhancer\ResourceEnhancer::class;
 
         // protects against "&cHash empty" error when `cacheHash.enforceValidation` is set to `true`