Skip to content

Commit 1c839d4

Browse files
committed
Disable minimal-versions CI tasks
I'm not sure they're worth it in this situation? At least, I haven't seen any breakage they would obviously have prevented.
1 parent 9e35620 commit 1c839d4

File tree

1 file changed

+23
-20
lines changed

1 file changed

+23
-20
lines changed

.github/workflows/tests.yml

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -131,26 +131,29 @@ jobs:
131131
- name: Test after cargo update
132132
run: cargo test --workspace
133133

134-
minimal-versions:
135-
needs: [test]
136-
strategy:
137-
matrix:
138-
os: [macOS-latest, ubuntu-latest, windows-latest]
139-
runs-on: ${{ matrix.os }}
140-
steps:
141-
- uses: actions/checkout@v4
142-
- uses: Swatinem/rust-cache@v2
143-
- uses: dtolnay/rust-toolchain@master
144-
with:
145-
toolchain: nightly
146-
- uses: taiki-e/install-action@v2
147-
name: Install nextest using install-action
148-
with:
149-
tool: nextest
150-
- name: Downgrade to minimal versions
151-
run: cargo +nightly -Zdirect-minimal-versions update
152-
- name: Test on minimal versions
153-
run: cargo test
134+
# Testing direct-minimal-versions seems to have unclear value for a binary
135+
# crate?
136+
#
137+
# minimal-versions:
138+
# needs: [test]
139+
# strategy:
140+
# matrix:
141+
# os: [macos-latest, ubuntu-latest, windows-latest]
142+
# runs-on: ${{ matrix.os }}
143+
# steps:
144+
# - uses: actions/checkout@v4
145+
# - uses: swatinem/rust-cache@v2
146+
# - uses: dtolnay/rust-toolchain@master
147+
# with:
148+
# toolchain: nightly
149+
# - uses: taiki-e/install-action@v2
150+
# name: install nextest using install-action
151+
# with:
152+
# tool: nextest
153+
# - name: downgrade to minimal versions
154+
# run: cargo +nightly -zdirect-minimal-versions update
155+
# - name: test on minimal versions
156+
# run: cargo test
154157

155158
tests-from-tarball:
156159
needs: [quick-check]

0 commit comments

Comments
 (0)