Skip to content

Commit 54dfe07

Browse files
feat(deps): angular version upgrade and converted into workspace (#65)
BREAKING CHANGE: YES ## Description This pull request introduces significant refactoring and modernization of the `SearchComponent` in the `search-lib` package, focusing on adopting Angular's new signal-based inputs/outputs, streamlining configuration management, and improving testability. Additionally, it includes workspace and dependency updates at the root level, and some cleanup of outdated scripts and files. Fixes #64 ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Intermediate change (work in progress) ## Checklist: - [x] Performed a self-review of my own code - [x] npm test passes on your machine - [ ] New tests added or existing tests modified to cover all changes - [ ] Code conforms with the style guide - [ ] API Documentation in code was updated - [ ] Any dependent changes have been merged and published in downstream modules
1 parent 16de31a commit 54dfe07

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+45232
-24021
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,14 @@ jobs:
2222
- run: node --version
2323
- run: npm --version
2424

25+
- name: Install Chrome
26+
uses: browser-actions/setup-chrome@v1
27+
2528
- name: Install Monorepo Deps
2629
run: npm ci --ignore-scripts
2730

28-
- name: Install Lerna
29-
run: npm i -g [email protected] --ignore-scripts
30-
31-
- name: Bootstrap Monorepo
32-
run: lerna bootstrap --ignore-scripts
33-
3431
- name: Run Test Cases
35-
run: npx lerna run test
32+
run: npm run test --workspaces --if-present
3633

3734
- name: Run Lint Checks
38-
run: npx lerna run lint
35+
run: npm run lint --workspaces --if-present

.github/workflows/pull_request.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,5 @@ jobs:
2323
if: steps.cache-nodemodules.outputs.cache-hit != 'true'
2424
run: npm ci --ignore-scripts
2525

26-
- name: Install Lerna
27-
run: npm i -g [email protected] --ignore-scripts
28-
29-
- name: Bootstrap Monorepo
30-
run: lerna bootstrap --ignore-scripts
31-
3226
- name: Run test
33-
run: lerna run test
27+
run: npm run test --workspaces --if-present

lerna.json

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,11 @@
11
{
22
"packages": [
33
"packages/search/projects/search-lib",
4-
"packages/search/projects/search-element"
4+
"packages/search/projects/search-element",
5+
"packages/user-onboarding/projects/user-onboarding-lib",
6+
"packages/user-onboarding/projects/user-onboarding-element"
57
],
68
"command": {
7-
"bootstrap": {
8-
"concurrency": 4,
9-
"ignore": [
10-
"@sourceloop/chat-notif-example_ui",
11-
"@sourceloop/search-client-example",
12-
"@sourceloop/payment-example-frontend",
13-
"@sourceloop/user-onboarding-example",
14-
"@sourceloop/chat-notif-example-ui-socket",
15-
"@sourceloop/oauth-example-ui",
16-
"@sourceloop/ai-assistant-example"
17-
]
18-
},
199
"version": {
2010
"conventionalCommits": true,
2111
"message": "chore(release): publish"

0 commit comments

Comments
 (0)