fix(chore): fix sonar code smells (#86)

* fix(chore): fix sonar code smells

resolving sonar code smells to improve quality gate

GH-78

* fix(chore): fix sonar code smells

Resolving sonar code smells to improve quality gate

GH-78

* refactor(chore): fix sonar code smells

and rebase

GH-78

---------

Co-authored-by: Shubham P <[email protected]>

Author: RaghavaroraSF

src/enhancer/spec-description-enhancer.ts

@@ -20,24 +20,24 @@ export class DescSpecEnhancer implements OASEnhancer {
   modifySpec(spec: OpenAPIObject): OpenApiSpec {
     for (const controller of this.app.find(`${CoreBindings.CONTROLLERS}.*`)) {
       const ctor = controller.valueConstructor;
-      if (ctor) {
-        const endpoints = MetadataInspector.getAllMethodMetadata<RestEndpoint>(
-          'openapi-v3:methods',
-          ctor.prototype,
-        );
-        for (const route in endpoints) {
-          const routeData = endpoints[route];
-          if (
-            routeData?.spec?.description &&
-            !spec.paths[routeData.path][routeData.verb].description
-          ) {
-            spec.paths[routeData.path][routeData.verb].description =
-              routeData.spec.description;
-          }
+      if (!ctor) {
+        continue;
+      }
+      const endpoints = MetadataInspector.getAllMethodMetadata<RestEndpoint>(
+        'openapi-v3:methods',
+        ctor.prototype,
+      );
+      for (const route in endpoints) {
+        const routeData = endpoints[route];
+        if (
+          routeData?.spec?.description &&
+          !spec.paths[routeData.path][routeData.verb].description
+        ) {
+          spec.paths[routeData.path][routeData.verb].description =
+            routeData.spec.description;
         }
       }
     }
-
     return spec;
   }
 }

src/providers/authorization-action.provider.ts

@@ -27,17 +27,21 @@ export class AuthorizeActionProvider implements Provider<AuthorizeFn> {
 
     if (request && this.checkIfAllowedAlways(request)) {
       return true;
-    } else if (!metadata) {
+    }
+
+    if (metadata) {
+      if (metadata.permissions.indexOf('*') === 0) {
+        // Return immediately with true, if allowed to all
+        // This is for publicly open routes only
+        return true;
+      }
+    } else {
       try {
         await this.requestContext.get(CoreBindings.CONTROLLER_METHOD_NAME);
         return false;
       } catch (error) {
         throw new HttpErrors.NotFound('API not found !');
       }
-    } else if (metadata.permissions.indexOf('*') === 0) {
-      // Return immediately with true, if allowed to all
-      // This is for publicly open routes only
-      return true;
     }
 
     const permissionsToCheck = metadata.permissions;

src/providers/casbin-authorization-action.provider.ts

@@ -41,13 +41,18 @@ export class CasbinAuthorizationProvider
 
       if (request && this.checkIfAllowedAlways(request)) {
         return true;
-      } else if (!metadata) {
-        return false;
-      } else if (metadata.permissions?.indexOf('*') === 0) {
+      }
+
+      if (metadata?.permissions?.indexOf('*') === 0) {
         // Return immediately with true, if allowed to all
         // This is for publicly open routes only
         return true;
-      } else if (!metadata.resource) {
+      }
+
+      if (!metadata?.resource) {
+        if (!metadata) {
+          return false;
+        }
         throw new HttpErrors.Unauthorized(
           `Resource parameter is missing in the decorator.`,
         );
@@ -56,7 +61,6 @@ export class CasbinAuthorizationProvider
       if (!user.id) {
         throw new HttpErrors.Unauthorized(`User not found.`);
       }
-
       const subject = this.getUserName(`${user.id}`);
 
       let desiredPermissions;

src/providers/casbin-enforcer-config.provider.ts

@@ -6,7 +6,9 @@ import {HttpErrors} from '@loopback/rest';
 export class CasbinEnforcerProvider
   implements Provider<CasbinEnforcerConfigGetterFn>
 {
-  constructor() {}
+  constructor() {
+    //This is intentional
+  }
 
   value(): CasbinEnforcerConfigGetterFn {
     return async (

src/providers/user-permissions.provider.ts

@@ -5,7 +5,9 @@ import {UserPermission, UserPermissionsFn} from '../types';
 export class UserPermissionsProvider
   implements Provider<UserPermissionsFn<string>>
 {
-  constructor() {}
+  constructor() {
+    //This is intentional
+  }
 
   value(): UserPermissionsFn<string> {
     return (userPermissions, rolePermissions) =>
@@ -27,6 +29,8 @@ export class UserPermissionsProvider
       } else if (!userPerm.allowed && perms.indexOf(userPerm.permission) >= 0) {
         // Remove permission if it is disallowed for user
         perms.splice(perms.indexOf(userPerm.permission), 1);
+      } else {
+        //this is intentional
       }
     });
     return perms;