refactor(all-services): fix sonarqube issues (#2358)

* refactor(all-services): fix sonarqube issues

GH-2356

* refactor(all-services): fix sonarqube issues

GH-2356

Author: vaibhavbhalla2505

packages/ocr-parser/projects/ocr-parser-lib/src/lib/ocr-parser/directives/text-select.directive.ts

@@ -9,6 +9,7 @@ import {
   OnDestroy,
   OnInit,
   NgZone,
+  Output,
 } from '@angular/core';
 export interface TextSelectEvent {
   text: string;
@@ -23,10 +24,9 @@ export interface SelectionRectangle {
 }
 @Directive({
   selector: '[textSelect]',
-  outputs: ['textSelectEvent: textSelect'],
 })
 export class TextSelectDirective implements OnInit, OnDestroy {
-  public textSelectEvent: EventEmitter<TextSelectEvent>;
+  @Output('textSelect') textSelectEvent = new EventEmitter<TextSelectEvent>();
   private readonly elementRef: ElementRef;
   private hasSelection: boolean;
   private readonly zone: NgZone;

sandbox/auth-multitenant-example/src/providers/casbin-authorization-action.provider.ts

@@ -96,9 +96,9 @@ export class CasbinAuthorizationProvider
     desiredPermissions: string[],
     enforcer: casbin.Enforcer,
     subject: string,
-    authDecision: boolean,
+    authDecision = false,
   ) {
-    let decision = authDecision ?? false;
+    let decision = authDecision;
     for (const resourceId of resourceIds) {
       for (const permission of desiredPermissions) {
         decision = await enforcer.enforce(subject, permission, resourceId);

sandbox/build.sh

@@ -4,19 +4,19 @@ CURRENT_DIR=$2
 
 # TODO: remove sudo once build agent is fixed
 
-if [ -z "$REGISTRY" ]; then
+if [[ -z "$REGISTRY" ]]; then
   REGISTRY="localhost:32000"
   echo "${REGISTRY}"
 else
   echo "${REGISTRY}"
 fi
 
-if [ ! -z "${DOCKER_USERNAME}" ] && [ ! -z "${DOCKER_PASSWORD}" ]; then
+if [[ ! -z "${DOCKER_USERNAME}" ]] && [[ ! -z "${DOCKER_PASSWORD}" ]]; then
   echo "Logging in to Docker"
   echo "${DOCKER_PASSWORD}" | docker login --username ${DOCKER_USERNAME} --password-stdin
 fi
 
-if [ -z "$CURRENT_DIR" ]; then
+if [[ -z "$CURRENT_DIR" ]]; then
   CURRENT_DIR=$(echo $PWD)
 fi
 

sandbox/ci_build.sh

@@ -11,6 +11,7 @@ install_kubectl() {
   sudo apt-get update -y
   sudo apt-get install -y kubectl
   kubectl cluster-info
+  return 0
 }
 
 install_microk8s() {
@@ -22,6 +23,7 @@ install_microk8s() {
   mkdir -p .kube
   microk8s config >.kube/config
   popd
+  return 0
 }
 
 local_docker_push() {
@@ -35,7 +37,7 @@ local_docker_push() {
   docker push ${LOCAL_REGISTRY}/search-ms-example
   docker push ${LOCAL_REGISTRY}/chat-notification-pubnub-example
   docker push ${LOCAL_REGISTRY}/feature-toggle-example
-
+  return 0
 }
 
 docker_push() {
@@ -60,7 +62,7 @@ docker_push() {
   docker push ${DOCKER_USERNAME}/search-ms-example
   docker push ${DOCKER_USERNAME}/chat-notification-pubnub-example
   docker push ${DOCKER_USERNAME}/feature-toggle-example
-
+  return 0
   # TODO: should we clean up after build? Since agent is ephemeral, some caching may be helpful after an initial run
   # TODO: remove specific images and cache
   #  docker system prune -a -f
@@ -71,26 +73,29 @@ terraform_apply() {
   terraform init
   terraform apply -auto-approve
   popd
+  return 0
 }
 
 terraform_destroy() {
   pushd ${CURRENT_DIR}/k8s/tf-sourceloop-sandbox
   terraform destroy -auto-approve
   popd
+  return 0
 }
 
 run_tests() {
   echo "Sleeping to wait for services to come online."
   sleep 180
   ${CURRENT_DIR}/health_check.sh sourceloop.local true
+  return 0
 }
 
-if [ ! -z "${DOCKER_USERNAME}" ] && [ ! -z "${DOCKER_PASSWORD}" ]; then
+if [[ ! -z "${DOCKER_USERNAME}" ]] && [[ ! -z "${DOCKER_PASSWORD}" ]]; then
   echo "Logging in to Docker"
   echo "${DOCKER_PASSWORD}" | docker login --username ${DOCKER_USERNAME} --password-stdin
 fi
 
-if [ -z "$CURRENT_DIR" ]; then
+if [[ -z "$CURRENT_DIR" ]]; then
   CURRENT_DIR=$(echo $PWD)
 fi
 
@@ -101,7 +106,7 @@ sudo chmod +x ${CURRENT_DIR}/docker-compose
 
 sudo REGISTRY=$LOCAL_REGISTRY ./docker-compose -f "${CURRENT_DIR}/docker-compose.yml" build
 
-if [ "${INSTALL_MICROK8S}" = "true" ]; then
+if [[ "${INSTALL_MICROK8S}" = "true" ]]; then
   install_microk8s
   install_kubectl
 fi

sandbox/health_check.sh

@@ -4,13 +4,13 @@ IS_LOCALHOST=$2
 ERROR_COUNT=0
 
 # check the basic health check on its own
-if [ "$IS_LOCALHOST" = "true" ]; then
+if [[ "$IS_LOCALHOST" = "true" ]]; then
   curl_response=$(curl -Is -H "Host: health-check.${DOMAIN}" https://localhost --insecure -f)
 else
   curl_response=$(curl -Is -H "Host: health-check.${DOMAIN}" https://health-check.${DOMAIN} --insecure -f)
 fi
 
-if [ -z "$curl_response" ]; then
+if [[ -z "$curl_response" ]]; then
   echo "health-check service is unhealthy"
   ERROR_COUNT=$((ERROR_COUNT + 1))
 fi
@@ -19,13 +19,13 @@ fi
 declare -a services=("workflow" "scheduler" "notification" "in-mail" "auth" "audit")
 
 for service in "${services[@]}"; do
-  if [ "$IS_LOCALHOST" = "true" ]; then
+  if [[ "$IS_LOCALHOST" = "true" ]]; then
     curl_response=$(curl -Is -H "Host: ${service}.${DOMAIN}" https://localhost/openapi.json --insecure -f)
   else
     curl_response=$(curl -Is -H "Host: ${service}.${DOMAIN}" https://${service}.${DOMAIN}/openapi.json --insecure -f)
   fi
 
-  if [ -z "$curl_response" ]; then
+  if [[ -z "$curl_response" ]]; then
     echo "${service} service is unhealthy"
     ERROR_COUNT=$((ERROR_COUNT + 1))
   fi

sandbox/telemed-app/backend/authentication-service/src/config.ts

@@ -21,7 +21,7 @@ let secret: SecretEnv;
 
 export async function getSecretValue() {
   let response;
-  // eslint-disable-next-line
+  // eslint-disable-next-line no-useless-catch
   try {
     response = await client.send(
       new GetSecretValueCommand({

sandbox/telemed-app/backend/notification-service/src/config.ts

@@ -21,7 +21,7 @@ let secret: SecretEnv;
 
 export async function getSecretValue() {
   let response;
-  // eslint-disable-next-line
+  // eslint-disable-next-line no-useless-catch
   try {
     response = await client.send(
       new GetSecretValueCommand({

sandbox/telemed-app/backend/video-conferencing-service/src/config.ts

@@ -21,7 +21,7 @@ let secret: SecretEnv;
 
 export async function getSecretValue() {
   let response;
-  // eslint-disable-next-line
+  // eslint-disable-next-line no-useless-catch
   try {
     response = await client.send(
       new GetSecretValueCommand({

services/authentication-service/src/__tests__/unit/bearer-verify.provider.unit.ts

@@ -6,7 +6,25 @@ import {expect} from '@loopback/testlab';
 import {JwtKeysRepository} from '@sourceloop/core';
 import sinon from 'sinon';
 import {SignupBearerVerifyProvider} from '../../providers';
+function log() {
+  // This is intentional
+}
 
+function info() {
+  // This is intentional
+}
+
+function warn() {
+  // This is intentional
+}
+
+function error() {
+  // This is intentional
+}
+
+function debug() {
+  // This is intentional
+}
 describe('Bearer Verify Signup Service', () => {
   let bearerVerifyProvider: SignupBearerVerifyProvider;
   let jwtKeysRepo: JwtKeysRepository;
@@ -37,26 +55,6 @@ describe('Bearer Verify Signup Service', () => {
     });
   });
 
-  function log() {
-    // This is intentional
-  }
-
-  function info() {
-    // This is intentional
-  }
-
-  function warn() {
-    // This is intentional
-  }
-
-  function error() {
-    // This is intentional
-  }
-
-  function debug() {
-    // This is intentional
-  }
-
   function setUp() {
     jwtKeysRepo = sinon.createStubInstance(JwtKeysRepository); // Mock the repository
     bearerVerifyProvider = new SignupBearerVerifyProvider(jwtKeysRepo, logger);

services/authentication-service/src/__tests__/unit/jwt-payload.provider.unit.ts

@@ -17,7 +17,25 @@ import {
   UserLevelPermissionRepository,
   UserTenantRepository,
 } from '../../repositories';
+function log() {
+  // This is intentional
+}
 
+function info() {
+  // This is intentional
+}
+
+function warn() {
+  // This is intentional
+}
+
+function error() {
+  // This is intentional
+}
+
+function debug() {
+  // This is intentional
+}
 describe('JWT Payload Provider', () => {
   let roleRepo: StubbedInstanceWithSinonAccessor<RoleRepository>;
   let userLevelPermissionRepo: StubbedInstanceWithSinonAccessor<UserLevelPermissionRepository>;
@@ -68,26 +86,6 @@ describe('JWT Payload Provider', () => {
     });
   });
 
-  function log() {
-    // This is intentional
-  }
-
-  function info() {
-    // This is intentional
-  }
-
-  function warn() {
-    // This is intentional
-  }
-
-  function error() {
-    // This is intentional
-  }
-
-  function debug() {
-    // This is intentional
-  }
-
   function setUp() {
     roleRepo = createStubInstance(RoleRepository);
     userLevelPermissionRepo = createStubInstance(UserLevelPermissionRepository);