refactor(chore): fix sonarqube issues (#2288)

GH-2287

Co-authored-by: Vaibhav  Bhalla <[email protected]>

Author: vaibhavbhalla2505

packages/cache/src/services/strategies/redis-store.strategy.ts

@@ -80,7 +80,7 @@ export class RedisStoreStrategy implements ICacheStore {
       try {
         value = JSON.parse(value);
       } catch (e) {
-        // do nothing
+        throw new Error(`Failed to parse value: ${e.message}`);
       }
       return value as T;
     } else if (typeof res === 'number') {
@@ -94,7 +94,7 @@ export class RedisStoreStrategy implements ICacheStore {
         try {
           decoded = JSON.parse(decoded);
         } catch (e) {
-          // do nothing
+          throw new Error(`Failed to parse value: ${e.message}`);
         }
         return decoded;
       }) as T;

packages/cli/src/generators/scaffold/index.ts

@@ -62,7 +62,7 @@ export default class ScaffoldGenerator extends BaseGenerator<ScaffoldOptions> {
         },
       );
     } catch (error) {
-      this.log(chalk.cyan(`Error while adding jenkinsfile`));
+      this.log(chalk.cyan(`Error while adding jenkinsfile{error.message}`));
     }
   }
   async install() {

packages/core/src/casbin-secure-sequence.ts

@@ -42,7 +42,7 @@ const SequenceActions = RestBindings.SequenceActions;
 const isJsonString = (str: string) => {
   try {
     JSON.parse(str);
-  } catch (e) {
+  } catch (_) {
     return false;
   }
   return true;

packages/core/src/components/proxy-builder/types.ts

@@ -4,7 +4,7 @@
 // https://opensource.org/licenses/MIT
 import {AnyObject, Entity} from '@loopback/repository';
 import {ModelConstructor, RestRelationConfig} from './services';
-
+export type HttpMethods = 'GET' | 'POST' | 'PUT' | 'PATCH' | 'DELETE';
 export type ProxyBuilderConfig = Array<{
   /**
    * The `configs` property in the `ProxyBuilderConfig` type is an array of either {@link EntityRestConfig} objects
@@ -85,7 +85,7 @@ export type RestOperationTemplate = {
    *  operation like method, url, headers, etc
    */
   template: {
-    method: 'GET' | 'POST' | 'PUT' | 'PATCH' | 'DELETE';
+    method: HttpMethods;
     url: string;
     headers?: {
       Authorization?: '{token}' | string;

packages/core/src/secure-sequence.ts

@@ -41,7 +41,7 @@ const SequenceActions = RestBindings.SequenceActions;
 const isJsonString = (str: string) => {
   try {
     JSON.parse(str);
-  } catch (e) {
+  } catch (_) {
     return false;
   }
   return true;

packages/core/src/service-sequence.ts

@@ -36,7 +36,7 @@ const SequenceActions = RestBindings.SequenceActions;
 const isJsonString = (str: string) => {
   try {
     JSON.parse(str);
-  } catch (e) {
+  } catch (_) {
     return false;
   }
   return true;

sandbox/audit-ms-example/migration.js

@@ -10,7 +10,7 @@ try {
     isLocal = true;
   }
 } catch (err) {
-  console.info('\n');
+  console.error('Error while checking for .infolder:', err);
 }
 if (isLocal) {
   console.info(`Skipping migrations`);

sandbox/auth-ms-basic-example/src/repositories/user.repository.ts

@@ -105,7 +105,9 @@ export class UserRepository extends DefaultSoftCrudRepository<
       });
       await this.credentials(user.id).create(creds);
     } catch (err) {
-      throw new HttpErrors.UnprocessableEntity('Error while hashing password');
+      throw new HttpErrors.UnprocessableEntity(
+        `Error while hashing password ${err.message}`,
+      );
     }
     return user;
   }

sandbox/auth-ms-basic-example/src/services/user-ops.service.ts

@@ -162,7 +162,7 @@ export class UserOpsService {
     try {
       creds = user && (await this.userRepository.credentials(user.id).get());
     } catch (e) {
-      //do nothing
+      throw new Error(`Error fetching credentials for user ${e.message}`);
     }
     if (!user || user.deleted) {
       throw new HttpErrors.Unauthorized(AuthenticateErrorKeys.UserDoesNotExist);

sandbox/auth-multitenant-example/src/application.ts

@@ -51,7 +51,7 @@ export class AuthMultitenantExampleApplication extends BootMixin(
         includeProcessEnv: true,
       });
     }
-    options.rest = options.rest || {};
+    options.rest = options.rest ?? {};
     options.rest.port = +(process.env.PORT ?? port);
     options.rest.host = process.env.HOST;
     super(options);