Skip to content

Commit 5f83920

Browse files
refactor(authentication-service): update urls and add scope for keycloak idp (#2176)
* refactor(authentication-service): update urls and add scope for keycloak idp update urls and add scope for keycloak idp BREAKING CHANGE: yes 47 * refactor(authentication-service): add realm to kecloak host env add realm to kecloak host env BREAKING CHANGE: yes 0 * docs(authentication-service): update readme for keycloak url changes update readme for keycloak url changes gh-0 --------- Co-authored-by: yeshamavani <[email protected]>
1 parent e1bba2c commit 5f83920

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

services/authentication-service/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ Authenttication service can be used as a identity server. Following endpoints ha
464464
<tr>
465465
<td>KEYCLOAK_HOST</td>
466466
<td>N</td>
467-
<td>Hostname of the Keycloak instance</td>
467+
<td>Hostname of the Keycloak instance. For all keycloak version below 17, user can still use this by only updating the KEYCLOCK_HOST and appending '/auth/realms' to its existing value</td>
468468
<td></td>
469469
</tr>
470470
<tr>

services/authentication-service/src/modules/auth/controllers/keycloak-login.controller.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,10 @@ export class KeycloakLoginController {
6464
//'e607fd75-adc8-4af7-9f03-c9e79a4b8b72',
6565
callbackURL: process.env.KEYCLOAK_CALLBACK_URL,
6666
//'http://localhost:3001/auth/keycloak-auth-redirect',
67-
authorizationURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/auth`,
68-
tokenURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/token`,
69-
userInfoURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/userinfo`,
67+
authorizationURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/auth`,
68+
tokenURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/token`,
69+
userInfoURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/userinfo`,
70+
scope: process.env.KEYCLOAK_SCOPE ?? 'openid',
7071
},
7172
queryGen('body'),
7273
)
@@ -108,9 +109,10 @@ export class KeycloakLoginController {
108109
//'e607fd75-adc8-4af7-9f03-c9e79a4b8b72',
109110
callbackURL: process.env.KEYCLOAK_CALLBACK_URL,
110111
//'http://localhost:3001/auth/keycloak-auth-redirect',
111-
authorizationURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/auth`,
112-
tokenURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/token`,
113-
userInfoURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/userinfo`,
112+
authorizationURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/auth`,
113+
tokenURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/token`,
114+
userInfoURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/userinfo`,
115+
scope: process.env.KEYCLOAK_SCOPE ?? 'openid',
114116
},
115117
queryGen('query'),
116118
)
@@ -149,9 +151,10 @@ export class KeycloakLoginController {
149151
//'e607fd75-adc8-4af7-9f03-c9e79a4b8b72',
150152
callbackURL: process.env.KEYCLOAK_CALLBACK_URL,
151153
//'http://localhost:3001/auth/keycloak-auth-redirect',
152-
authorizationURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/auth`,
153-
tokenURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/token`,
154-
userInfoURL: `${process.env.KEYCLOAK_HOST}/auth/realms/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/userinfo`,
154+
authorizationURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/auth`,
155+
tokenURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/token`,
156+
userInfoURL: `${process.env.KEYCLOAK_HOST}/${process.env.KEYCLOAK_REALM}/protocol/openid-connect/userinfo`,
157+
scope: process.env.KEYCLOAK_SCOPE ?? 'openid',
155158
},
156159
queryGen('query'),
157160
)

0 commit comments

Comments
 (0)