Skip to content

Commit 0b4e4c2

Browse files
committed
fix(core): is column should be mandatory
is column needs to be mandatory in valid WF GH-72
1 parent 284545b commit 0b4e4c2

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

projects/workflows-creator/src/lib/builder/builder.component.ts

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ import {
4848
} from '../types';
4949
import {LocalizationProviderService} from '../services/localization-provider.service';
5050
import {LocalizationPipe} from '../pipes/localization.pipe';
51+
import {ConditionInput} from '../services';
5152
@Component({
5253
selector: 'workflow-builder',
5354
templateUrl: './builder.component.html',
@@ -487,6 +488,14 @@ export class BuilderComponent<E> implements OnInit, OnChanges {
487488
case ActionTypes.ChangeColumnValueAction:
488489
const columnExists = !!node.node.state.get('column');
489490
let valueExists = false;
491+
const valueTypeIsAnyValue =
492+
node.node.state.get('valueType') === ValueTypes.AnyValue;
493+
let conditionExist = false;
494+
if (node.node.prompts.includes(ConditionInput.identifier)) {
495+
conditionExist = !!node.node.state.get('condition');
496+
} else {
497+
conditionExist = true;
498+
}
490499
if (typeof node.node.state.get('value') !== 'undefined') {
491500
valueExists = true;
492501
} else if (
@@ -496,9 +505,11 @@ export class BuilderComponent<E> implements OnInit, OnChanges {
496505
} else {
497506
valueExists = !!node.node.state.get('value');
498507
}
499-
const valueTypeIsAnyValue =
500-
node.node.state.get('valueType') === ValueTypes.AnyValue;
501-
isValid = columnExists && (valueExists || valueTypeIsAnyValue);
508+
509+
isValid =
510+
columnExists &&
511+
(valueExists || valueTypeIsAnyValue) &&
512+
conditionExist;
502513
break;
503514
case EventTypes.OnIntervalEvent:
504515
const intervalExists = !!node.node.state.get('interval');

projects/workflows-element/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
"access": "public",
1818
"directory": "dist"
1919
},
20-
"hash": "2de169ac759548f51f2397daa81b6187fa75d7ca99c31f0f14e9ab95335919fb"
20+
"hash": "e7d87648d791167bdf0951718bdf5aa7fd8813267d827776af30b4e2f6d3741e"
2121
}
2222

0 commit comments

Comments
 (0)